Problem/Motivation

Drupal\Core\Access\AccessResult::cacheUntilConfigurationChanges is deprecated but we still use it.

Proposed resolution

Add @trigger_error() to the method and remove usages.

Remaining tasks

None

User interface changes

none

API changes

none

Data model changes

none

Release notes snippet

N/a

CommentFileSizeAuthor
#6 3069028-6.patch4.1 KBalexpott
#6 3-6-interdiff.txt1.54 KBalexpott
#3 3069028-2.patch2.57 KBalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mikelutz created an issue. See original summary.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented

edit: wrong issue

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
FileSize
3069028-2.patch2.57 KB
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Issue summary: View changes
Status: Active » Needs review
mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
CreditAttribution: mikelutz as a volunteer and at ICON Interactive commented
Status: Needs review » Needs work
Issue tags: +Needs tests

Looks good, just needs a legacy test to test the deprecation error.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Needs work » Needs review
FileSize
3-6-interdiff.txt1.54 KB
3069028-6.patch4.1 KB

I think at some point we need to discuss whether deprecated one line methods with no logic need a test but now is not the time. (I don't think they do).

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs tests

Yeah, the more we add, the more work we have in 9.x to remove it again :)

Look good.

  • catch committed 6c18352 on 8.8.x 
    Issue #3069028 by alexpott: Properly Deprecate Drupal\Core\Access\...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed 6c18352 and pushed to 8.8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.