CommentFileSizeAuthor
#4 interfdiff-3069057-2-4.txt771 bytesvoleger
#4 3069057-4.patch1.08 KBvoleger
#2 3069057-2.patch1.02 KBvoleger
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mikelutz created an issue. See original summary.

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
CreditAttribution: voleger as a volunteer and at GOLEMS GABB, Drupal Ukraine Community for Drupal Ukraine Community, GOLEMS GABB commented
Status: Active » Needs review
FileSize
3069057-2.patch1.02 KB

Fix requires to remove extending the PHPUnit\Framework\BaseTestListener class and start using the PHPUnit\Framework\TestListenerDefaultImplementation trait.

Status: Needs review » Needs work

The last submitted patch, 2: 3069057-2.patch, failed testing. View results

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
CreditAttribution: voleger as a volunteer and at GOLEMS GABB, Drupal Ukraine Community for Drupal Ukraine Community, GOLEMS GABB commented
Status: Needs work » Needs review
FileSize
3069057-4.patch1.08 KB
interfdiff-3069057-2-4.txt771 bytes

Add fix issue with tests

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
CreditAttribution: mikelutz as a volunteer and at ICON Interactive commented
Status: Needs review » Reviewed & tested by the community

Straightforward adjustment for the phpunit deprecation. This can be done now that we don't support PHPunit 4 in Drupal 8.8

  • catch committed 39fcc67 on 8.8.x 
    Issue #3069057 by voleger, mikelutz: Fix Class extends deprecated class...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed 39fcc67 and pushed to 8.8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.