Drupal 9 Deprecated Code Report [#3069484]

Problem/Motivation

------ ---------------------------------------------------------------------- 
  Line   src/Form/DatalayerSettingsForm.php                                    
 ------ ---------------------------------------------------------------------- 
  178    Call to deprecated function drupal_set_message():                     
         in Drupal 8.5.0 and will be removed before Drupal 9.0.0.              
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.  
 ------ ---------------------------------------------------------------------- 
 
 [ERROR] Found 1 error

Proposed resolution

Replace the drupal_set_message() usage with the messenger service.

Comment	File	Size	Author
#4	datalayer-3069484-deprecated-code-4.patch	991 bytes	WidgetsBurritos
#4	8.x-1.x: PHP 7.2 & MySQL 5.5, D8.8 Patch Failed to Apply
#2	datalayer-3069484-deprecated-code-2.patch	912 bytes	WidgetsBurritos
#2	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.8 Composer error. Unable to continue. PHP 5.6 & MySQL 5.5, D8.8 Composer error. Unable to continue. PHP 7.2 & MySQL 5.5, D8.8 11 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

22 July 2019 at 21:33

WidgetsBurritos created an issue. See original summary.

Comment #2

WidgetsBurritos CreditAttribution: WidgetsBurritos at Rackspace commented 22 July 2019 at 21:34

Status:

Active

» Needs review

File	Size
datalayer-3069484-deprecated-code-2.patch	912 bytes
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.8 Composer error. Unable to continue. PHP 5.6 & MySQL 5.5, D8.8 Composer error. Unable to continue. PHP 7.2 & MySQL 5.5, D8.8 11 pass

Comment #3

WidgetsBurritos CreditAttribution: WidgetsBurritos at Rackspace commented 23 July 2019 at 01:43

PHP 5.5/5.6 build failures are unrelated. See #3069517: DrupalCI Test Runner is Broken

Patch is working in PHP 7.2

Comment #4

WidgetsBurritos CreditAttribution: WidgetsBurritos at Rackspace commented 5 August 2019 at 17:48

File	Size
datalayer-3069484-deprecated-code-4.patch	991 bytes
8.x-1.x: PHP 7.2 & MySQL 5.5, D8.8 Patch Failed to Apply

1 file was hidden/shown/deleted

File	Size
datalayer-3069484-deprecated-code-2.patch	912 bytes
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.8 Composer error. Unable to continue. PHP 5.6 & MySQL 5.5, D8.8 Composer error. Unable to continue. PHP 7.2 & MySQL 5.5, D8.8 11 pass

Per offline conversation with @pobtastic, we should use addWarning() instead of addMessage().

Comment #5

pobster CreditAttribution: pobster at ArcadeGeek LTD for Rackspace commented 5 August 2019 at 17:49

Status:

Needs review

» Reviewed & tested by the community

Great! Thank you :)

Comment #6

5 August 2019 at 17:55

WidgetsBurritos committed 654aa68 on 8.x-1.x

Issue #3069484 by WidgetsBurritos, pobtastic: Drupal 9 Deprecated Code...

Comment #7

WidgetsBurritos CreditAttribution: WidgetsBurritos at Rackspace commented 5 August 2019 at 17:57

Status:

Reviewed & tested by the community

» Fixed

Comment #8

WidgetsBurritos CreditAttribution: WidgetsBurritos at Rackspace commented 5 August 2019 at 17:57

Comment #9

WidgetsBurritos CreditAttribution: WidgetsBurritos at Rackspace commented 5 August 2019 at 17:57

Status:

Fixed

» Closed (fixed)

Comment #10

Kristen Pol

she/her

English

Santa Cruz, CA, USA

CreditAttribution: Kristen Pol at Hook 42 commented 28 November 2019 at 07:20

Issue tags:

+Drupal 9 compatibility

Per a Slack discussion with Gábor Hojtsy regarding usage of D9 tags (Drupal 9, Drupal 9 compatibility, Drupal 9 readiness, etc.), "Drupal 9 compatibility" should be used for contributed projects that need updating and "Drupal 9" was the old tag for D8 issues before the D9 branch was ready. Doing tag cleanup here based on that discussion.