The Readme must must be formatted as specified by README template : https://www.drupal.org/docs/develop/documenting-your-project/readme-temp...

CommentFileSizeAuthor
#6 3069645-6.patch2.17 KBshubham.prakash
#4 3069645-4.patch2.05 KBshubham.prakash
#2 3069645-2.patch2.04 KBshubham.prakash
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

shubham.prakash created an issue. See original summary.

shubham.prakash’s picture

shubham.prakash CreditAttribution: shubham.prakash at OpenSense Labs commented
Assigned: shubham.prakash » Unassigned
Status: Active » Needs review
FileSize
3069645-2.patch2.04 KB

This patch should fix the issue.

anmolgoyal74’s picture

anmolgoyal74 CreditAttribution: anmolgoyal74 at OpenSense Labs for DrupalFit commented
Status: Needs review » Needs work

CS issue: If the line declaring an array spans longer than 80 characters, each element should be broken into its own line.

shubham.prakash’s picture

shubham.prakash CreditAttribution: shubham.prakash at OpenSense Labs commented
Status: Needs work » Needs review
FileSize
3069645-4.patch2.05 KB

Thanks for the review, this patch should fix the issue.

alonaoneill’s picture

alonaoneill CreditAttribution: alonaoneill at Hook 42 commented
Status: Needs review » Needs work

Reviewed the patch for spelling and grammar. Everything looks good, but:

+++ b/README.md
@@ -0,0 +1,51 @@
+ * Install this module as you would normally install a contributed Drupal module.

Text should manually word-wrap within around 80 cols.
Also "Configuration" part is missing. The configuration section (required) is necessary even when little configuration is required.
I would add something like:
1. Navigate to Administration > Extend and enable the module.
2. Navigate to Administration > Structure > Block layout and "Place block" from "Financial Calculators" category.

shubham.prakash’s picture

shubham.prakash CreditAttribution: shubham.prakash at OpenSense Labs commented
Status: Needs work » Needs review
FileSize
3069645-6.patch2.17 KB

Here is the patch for same.

anmolgoyal74’s picture

anmolgoyal74 CreditAttribution: anmolgoyal74 at OpenSense Labs for DrupalFit commented
Status: Needs review » Reviewed & tested by the community

It's better now. Thanks for the patch.

gaurav.kapoor’s picture

gaurav.kapoor CreditAttribution: gaurav.kapoor commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.