Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
The Readme must must be formatted as specified by README template : https://www.drupal.org/docs/develop/documenting-your-project/readme-temp...
Comment | File | Size | Author |
---|---|---|---|
#7 | 3070002-7.patch | 4.19 KB | shubham.prakash |
#4 | latex-3070002-1.patch | 2.22 KB | joy29 |
#2 | 3070002-2.patch | 3.67 KB | shubham.prakash |
Comments
Comment #2
shubham.prakash CreditAttribution: shubham.prakash at OpenSense Labs commentedComment #3
joy29 CreditAttribution: joy29 at Srijan | A Material+ Company commentedLooks good, but readme.txt should README.txt
Comment #4
joy29 CreditAttribution: joy29 at Srijan | A Material+ Company commentedComment #5
shubham.prakash CreditAttribution: shubham.prakash at OpenSense Labs commentedThe patch is #4 does not follow the documentation standards. Thanks.
Comment #6
alonaoneill CreditAttribution: alonaoneill at Hook 42 commentedI reviewed patch in comment #2
Everything looks good, but it needs some small changes:
Text should manually word-wrap within around 80 cols.
Extra space should be removed in line 47!
Comment #7
shubham.prakash CreditAttribution: shubham.prakash at OpenSense Labs commentedThanks for the review, this patch should fix the issue.
Comment #8
alonaoneill CreditAttribution: alonaoneill at Hook 42 commentedReviewed the patch for spelling and grammar. Formatting aligns to Drupal documentation standards.
Everything looks good. Patch applied.
Marking as RTBCed.
Thank you for working on module!
Comment #10
gaurav.kapoor CreditAttribution: gaurav.kapoor commented