Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
In #3053199: Add SHA256SUMS file of all files, we have live SHA sums. Let's make the necessary modifications to make this module work with those URLs.
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#32 | 3071193-32.patch | 20.87 KB | heddn |
#32 | interdiff_31-32.txt | 806 bytes | heddn |
Comments
Comment #2
heddnThere's a few more things that need fixing, but this get's us started. The nice thing is that the sha sums provided from #3053199: Add SHA256SUMS file of all files just work.
Comment #3
heddnThis fixes up a few more things in manual testing. Let's see how automated tests fare.
Comment #4
heddnphpcs
Comment #6
heddnComment #7
heddnComment #9
heddnComment #10
heddnComment #11
heddnOne other thing we need now is a test for a contrib project. Setting to NW for that. Since apart from the minor refactoring of how we are getting the info file details, that is the area that caused manual testing to fail.
Comment #12
heddnAnd now we have tests.
Comment #13
heddnComment #14
catchI might be missing something but I can't see anywhere in the patch or the current code where $this->{$extension_type} gets set or where it's defined as a property. Didn't pick up anything major in the review.
Comment #15
heddnGood catch in #14. This should fix that.
Comment #16
heddnWe're going to say RTBC.
Comment #18
heddnNeeds backport now.
Comment #19
heddnHere's the first part of using slightly patched version of
drupal/php-signify
.This patch also utilizes https://github.com/drupal/php-signify/pull/5. Tests pass locally. Will fail on do.o.
Comment #20
heddnIt will decidedly break. Wrong branch. W/ the signify work, D8 changed and patch in #19 was against 8.x.
Comment #21
heddnComment #23
heddnComment #24
heddnComment #25
heddnThis will fail for several reasons, including the build test type doesn't exist yet and even if it did, it is still failing on local builds. But it is the latest thinking.
Comment #26
heddnComment #27
heddnThis is a quick and dirty fix of tests for core. I didn't test contrib. It depends on local changes to
drupal/php-signify
and drupal core for the new build test type, so it isn't particularly help to run this on the testbot.Comment #28
heddnNeeded changes for
drupal/php-signify
are in. And now the tests pass for core and contrib (when tested w/ the core patch).Comment #29
heddnRe-roll of #28 now that things upstream have landed.
Comment #30
heddnComment #31
heddnComment #32
heddnComment #34
heddnThis is blocking several follow-up things, so going to commit this. Ideally this will be reviewed more completely at a later point. Besides expanded testing, the biggest changes here are simply wiring up to use php-signify.