Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Line tabledrag_example/tabledrag_example.install
Call to deprecated function db_drop_table(): in drupal:8.0.0 and will be removed from drupal:9.0.0. Instead, get a database connection injected into your service from the container, get its schema driver, and call dropTable() on it.
Comment | File | Size | Author |
---|---|---|---|
#15 | 3072418-15.patch | 476 bytes | andypost |
|
Comments
Comment #2
SerShevchykComment #3
dpovshed CreditAttribution: dpovshed as a volunteer and at Drupal Ukraine Community commentedI would suggest using the same syntax and variable names as in the tabledrag_example_install() function, i.e.
Comment #4
SerShevchykComment #5
SerShevchykComment #6
dpovshed CreditAttribution: dpovshed as a volunteer and at Drupal Ukraine Community commentedLooks good to me!
Comment #7
andypostComment #8
lyalyuk CreditAttribution: lyalyuk at Drupal Ukraine Community for Drupal Ukraine Community commentedThis issue is already fixed here https://www.drupal.org/project/examples/issues/3072411
Comment #9
valthebald@lyalyuk it's harder to review bigger patches that cover multiple deprecations. Do you coordinate/track the changes that happen in other tickets?
Comment #10
valthebaldCrediting @dpovshed for the review
Comment #11
SerShevchykunassigned by maintainer's request
Comment #12
lyalyuk CreditAttribution: lyalyuk at Drupal Ukraine Community for Drupal Ukraine Community commented@valthebald Yep, we were a little miscoordinated here but now everything is ok. My patch in the https://www.drupal.org/project/examples/issues/3072411 contains all our work on the `tabledrag_example`
The huge part of the patch is just moving function tabledrag_example_data into a static method in TableDragExampleResetForm. Cause drupal-check claims on module_load_include.
I think using module_load_include doesn't make a sense in the border of one module. And I suppose the static method will work faster.
Comment #13
valthebald@lyalyuk awesome!
Comment #14
andypostI think better commit per file/per case - this one perfectly separate since 8.0
Comment #15
andypostThe proper fix is like #3072411: Fix tabledrag_example module to allow drupal-check run and convert tabledrag_example_data() usage
So no reason for intermediate variable here, sounds like good enough to be separate
Comment #17
valthebaldCommitted and pushed to 8.x-1.x, thank you all!
Comment #19
Kristen PolPer a Slack discussion with Gábor Hojtsy regarding usage of D9 tags (Drupal 9, Drupal 9 compatibility, Drupal 9 readiness, etc.), "Drupal 9 compatibility" should be used for contributed projects that need updating and "Drupal 9" was the old tag for D8 issues before the D9 branch was ready. Doing tag cleanup here based on that discussion.