Problem/Motivation

Annotation of the Crop Entity Type contains a declaration of the translation handler. However, this is not necessary, because this handler will be added automatically by content_translation module. According to the content_translation_entity_type_alter() function comment:

If the entity paths match the default pattern above and there is no need for an entity-specific translation handler, Content Translation will provide built-in support for the entity.

Proposed resolution

Remove translation handler.

Remaining tasks

-

User interface changes

-

API changes

-

Data model changes

-

Release notes snippet

-

CommentFileSizeAuthor
#2 crop-remove-translation-handler-3072690-2-D8.patch559 bytesid.aleks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

id.aleks created an issue. See original summary.

id.aleks’s picture

id.aleks CreditAttribution: id.aleks at Smile commented
Assigned: id.aleks » Unassigned
Status: Active » Needs review
FileSize
crop-remove-translation-handler-3072690-2-D8.patch559 bytes

Please test and apply.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Reviewed & tested by the community

I'd rather it not be translatable at all as that doesn't make sense, but that is going to be much harder, this seems does make sense.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Reviewed & tested by the community » Fixed

Agreed. This is removing redundant code and tests pass, so committed and pushed to 8.x-2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.