php drupal-check.phar modules/contrib/entity_activity/
 84/84 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ---------------------------------------------------------------------------------------------------------------------------------------- 
  Line   src/EntityActivityManager.php                                                                                                           
 ------ ---------------------------------------------------------------------------------------------------------------------------------------- 
         Class Drupal\entity_Activity\PurgeInterval was not found while trying to analyse it - autoloading is probably not configured properly.  
 ------ ---------------------------------------------------------------------------------------------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/GeneratorDeleteForm.php                   
 ------ --------------------------------------------------- 
  41     Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   src/Plugin/Field/FieldFormatter/LogReadFormatter.php                                                                                                                   
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
         Class Drupal\entity_Activity\Plugin\Field\FieldFormatter\LogReadFormatter was not found while trying to analyse it - autoloading is probably not configured properly.  
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   src/Plugin/LogGeneratorInterface.php                                                                                                             
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------- 
  14     Interface Drupal\entity_activity\Plugin\LogGeneratorInterface extends deprecated interface Drupal\Component\Plugin\ConfigurablePluginInterface.  
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------------------------------------------------------------------------- 
  Line   src/PurgeInterval.php                                                                                                                   
 ------ ---------------------------------------------------------------------------------------------------------------------------------------- 
         Class Drupal\entity_Activity\PurgeInterval was not found while trying to analyse it - autoloading is probably not configured properly.  
 ------ ---------------------------------------------------------------------------------------------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 5 errors  
CommentFileSizeAuthor
#2 deprecated-3073443-2.patch1.46 KBSergiu Stici
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Sergiu Stici created an issue. See original summary.

Sergiu Stici’s picture

Status: Active » Needs review
FileSize
1.46 KB

Here's the patch, please review.

flocondetoile’s picture

Status: Needs review » Needs work

Thanks for your help

This commit fix the following issues

- removed drupal_set_message()
- fix the typo in namespace (entity_Activity instead if entity_activity)
- Remove the PurgeInterval class (wich has has a typo issue) in favor of the final class Interval.

Could you rerun drupal-check again ?

There should be only one error about ConfigurablePluginInterface. But this error needs its own issue because I don't want break sites under 8.6.x. The fix about this deprecated interface could be committed once support for 8.6.x is dropped.

flocondetoile’s picture

flocondetoile’s picture

Status: Needs work » Fixed

drupal-check report added on the child issue

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.