php drupal-check.phar modules/contrib/rate/
 35/35 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ -------------------------------------------------------------------------------------- 
  Line   src/Plugin/VoteResultFunction/CountUp.php                                             
 ------ -------------------------------------------------------------------------------------- 
         Class Drupal\votingapi\VoteResultFunctionBase not found and could not be autoloaded.  
 ------ -------------------------------------------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/RateBotDetector.php                            
 ------ --------------------------------------------------- 
  170    Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   tests/src/Functional/RateWidgetTest.php            
 ------ --------------------------------------------------- 
  51     Call to deprecated function entity_get_display().  
 ------ --------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 3 errors
CommentFileSizeAuthor
#11 rate-3073450-11.patch983 bytesKrzysztof Domański
#5 interdiff-2-5.txt883 bytesKrzysztof Domański
#5 3073450-5.patch2.7 KBKrzysztof Domański
#2 deprecated-3073450-2.patch3.5 KBSergiu Stici
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Sergiu Stici created an issue. See original summary.

Sergiu Stici’s picture

Sergiu Stici CreditAttribution: Sergiu Stici at FFW commented
Status: Active » Needs review
FileSize
deprecated-3073450-2.patch3.5 KB

Here's the patch, please review.

Status: Needs review » Needs work

The last submitted patch, 2: deprecated-3073450-2.patch, failed testing. View results

Krzysztof Domański’s picture

Krzysztof Domański
Location Poland
CreditAttribution: Krzysztof Domański at abventor commented
Title: Deprecated Code Report » Replace deprecated drupal_set_message() with \Drupal::messenger()

I split this task into two issues.

#3074633: Replace deprecated entity_get_display()

Krzysztof Domański’s picture

Krzysztof Domański
Location Poland
CreditAttribution: Krzysztof Domański at abventor commented
Status: Needs work » Needs review
FileSize
3073450-5.patch2.7 KB
interdiff-2-5.txt883 bytes
echo15’s picture

echo15 CreditAttribution: echo15 at EPAM Systems commented
Status: Needs review » Reviewed & tested by the community

Patch #5 Looks good. reviewed and tested.

Krzysztof Domański’s picture

Krzysztof Domański
Location Poland
CreditAttribution: Krzysztof Domański at abventor commented
Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Krzysztof Domański’s picture

Krzysztof Domański
Location Poland
CreditAttribution: Krzysztof Domański at abventor commented
Status: Closed (fixed) » Needs work

I realized that last changes may break BC. We can use here MessengerTrait instead of changing the constructor.

+   * @param \Drupal\Core\Messenger\MessengerInterface $messenger
+   *   The messenger.
    */
-  public function __construct(ConfigFactoryInterface $config_factory, Connection $database, Client $http_client, RequestStack $request_stack) {
+  public function __construct(ConfigFactoryInterface $config_factory, Connection $database, Client $http_client, RequestStack $request_stack, MessengerInterface $messenger) {
     $this->config = $config_factory->get('rate.settings');
Krzysztof Domański’s picture

Krzysztof Domański
Location Poland
CreditAttribution: Krzysztof Domański at abventor commented
Status: Needs work » Needs review
FileSize
rate-3073450-11.patch983 bytes

Krzysztof Domański’s picture

Krzysztof Domański
Location Poland
CreditAttribution: Krzysztof Domański at abventor commented
Status: Needs review » Fixed

Krzysztof Domański credited tomvanetten.

Krzysztof Domański’s picture

Krzysztof Domański
Location Poland
CreditAttribution: Krzysztof Domański at abventor commented
Parent issue: » #3091133: Create a drupal 9 port, drupal 9 report

Credited @tomvanetten for working on it in #3091133: Create a drupal 9 port, drupal 9 report.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.