Please replace Drupal::request() with DI usage in class SpreadshopConfigForm:

FILE: ...or/drupal/pareviewsh/pareview_temp/src/Form/SpreadshopConfigForm.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 302 | WARNING | \Drupal calls should be avoided in classes, use
     |         | dependency injection instead
--------------------------------------------------------------------------
CommentFileSizeAuthor
#5 3073778-5.patch2.11 KBvuil
#2 spreadshop-3073778-2.patch603 bytesjigish.addweb
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ilchovuchkov created an issue. See original summary.

jigish.addweb’s picture

jigish.addweb CreditAttribution: jigish.addweb at AddWeb Solution Pvt. Ltd. commented
Status: Active » Needs review
FileSize
spreadshop-3073778-2.patch603 bytes

@ilchovuchkov, Here's patch, I resolve the above standard error, Kindly review it & let me know if you still have any findings.

Thanks

is_drehmann’s picture

is_drehmann CreditAttribution: is_drehmann commented

@jigish.addweb

this is not working

Fatal error: Uncaught Error: Call to undefined method Drupal\spreadshop\Form\SpreadshopConfigForm::request() in /var/www/html/modules/custom/spreadshop/src/Form/SpreadshopConfigForm.php:302

is_drehmann’s picture

is_drehmann CreditAttribution: is_drehmann commented
Status: Needs review » Needs work
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at Bulpros Consulting commented
FileSize
3073778-5.patch2.11 KB
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at Bulpros Consulting commented
Status: Needs work » Needs review

is_drehmann’s picture

is_drehmann CreditAttribution: is_drehmann commented

LGTM

is_drehmann’s picture

is_drehmann CreditAttribution: is_drehmann commented
Status: Needs review » Closed (works as designed)
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at Bulpros Consulting commented
Status: Closed (works as designed) » Fixed
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at Bulpros Consulting commented
Status: Fixed » Closed (fixed)