Problem/Motivation

Open Video Duration meta tag is not supported.

@see #2319389: Add extra meta tags for og:type=video

Proposed resolution

Add og:video:duration tag

Remaining tasks

Copy code from #2319389: Add extra meta tags for og:type=video
Update tests
Approve

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

CommentFileSizeAuthor
#4 3074603-metatag.png54.29 KBcindytwilliams
#4 3074603-schema.png79.94 KBcindytwilliams
#4 3074603-field.png47.23 KBcindytwilliams
#3 metatag-adds-og-video-duration-3074603-3.patch2.03 KBthejimbirch
#2 metatag-3074603-2.patch1.38 KBjrockowitz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jrockowitz created an issue. See original summary.

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
Status: Active » Needs review
FileSize
metatag-3074603-2.patch1.38 KB
thejimbirch’s picture

thejimbirch CreditAttribution: thejimbirch at Kanopi Studios commented
FileSize
metatag-adds-og-video-duration-3074603-3.patch2.03 KB

Patch applied and added the tag as expected, but was missing the schema. New patch attached that adds it.

To Validate:
Apply the patch
Verify metatag_open_graph is enabled
Add/Edit and Meta tag default
Expand the Open Graph field set
Verify the Video duration (seconds) field is present

There is an issue to add test coverage for this scenario, Add test coverage to ensure each meta tag's config schema is created properly.

cindytwilliams’s picture

cindytwilliams CreditAttribution: cindytwilliams at Kanopi Studios commented
Status: Needs review » Reviewed & tested by the community
FileSize
3074603-field.png47.23 KB
3074603-schema.png79.94 KB
3074603-metatag.png54.29 KB

Patch #3 applied cleanly. The "Video duration (seconds)" field was added, as well as the og:video:duration meta tag and the schema.

Marking RTBC.

Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews commented
Parent issue: » #3078078: Plan for Metatag 8.x-1.11
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

So the D7 version doesn't have this, it has just video:duration, so I added a new issue to backport the change: #3089445: Add og:video:duration tag (D7)

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Reviewed & tested by the community » Fixed

I also updated Drupal\metatag\Plugin\migrate\process\d7\MetatagD7Entities so we can make sure we remember to get it into D7.

Committed. Thanks everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.