Capitalize the name of the module, because module names are proper nouns.
https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...
Patch to follow, thanks!

CommentFileSizeAuthor
#2 zchat-info-3075544-2.patch372 bytesalonaoneill
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alonaoneill created an issue. See original summary.

alonaoneill’s picture

alonaoneill CreditAttribution: alonaoneill at Hook 42 commented
Assigned: alonaoneill » Unassigned
Status: Active » Needs review
FileSize
zchat-info-3075544-2.patch372 bytes
Willtg’s picture

Willtg CreditAttribution: Willtg at Hook 42 commented

Code looks good. The dependency name-spacing aligns with Drupal documentation standards. Applied when tested with STM.
Marking as RTBC
Thank you for working on the module!

Willtg’s picture

Willtg CreditAttribution: Willtg at Hook 42 commented
Status: Needs review » Reviewed & tested by the community

aurelianzaha’s picture

aurelianzaha CreditAttribution: aurelianzaha at jobiqo - job board technology commented
Status: Reviewed & tested by the community » Fixed

Thanks for the patch.

aurelianzaha’s picture

aurelianzaha CreditAttribution: aurelianzaha at jobiqo - job board technology commented
Status: Fixed » Closed (fixed)