------ ----------------------------------------------------------------------
Line src/Element/MobileNumber.php
------ ----------------------------------------------------------------------
401 Call to deprecated function drupal_get_messages():
in Drupal 8.5.0 and will be removed before Drupal 9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::all() or
\Drupal\Core\Messenger\MessengerInterface::messagesByType() instead.
406 Call to deprecated function drupal_set_message():
in Drupal 8.5.0 and will be removed before Drupal 9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
------ ----------------------------------------------------------------------
------ ----------------------------------------------------------------------------------------------
Line src/Feeds/Target/MobileNumber.php
------ ----------------------------------------------------------------------------------------------
Class Drupal\feeds\Plugin\Type\Target\FieldTargetBase not found and could not be autoloaded.
------ ----------------------------------------------------------------------------------------------
-------------------------------------------------------------------------------------------------------------------
Line src/Plugin/TfaValidation/MobileNumberTfa.php
-------------------------------------------------------------------------------------------------------------------
Class MobileNumberTfa was not found while trying to analyse it - autoloading is probably not configured properly.
-------------------------------------------------------------------------------------------------------------------
------ -----------------------------------------------------------------------------------
Line src/Plugin/Validation/Constraint/MobileNumberValidator.php
------ -----------------------------------------------------------------------------------
54 Call to deprecated method strtolower() of class Drupal\Component\Utility\Unicode:
in Drupal 8.6.0, will be removed before Drupal 9.0.0. Use
mb_strtolower() instead.
64 Call to deprecated method strtolower() of class Drupal\Component\Utility\Unicode:
in Drupal 8.6.0, will be removed before Drupal 9.0.0. Use
mb_strtolower() instead.
70 Call to deprecated method strtolower() of class Drupal\Component\Utility\Unicode:
in Drupal 8.6.0, will be removed before Drupal 9.0.0. Use
mb_strtolower() instead.
77 Call to deprecated method strtolower() of class Drupal\Component\Utility\Unicode:
in Drupal 8.6.0, will be removed before Drupal 9.0.0. Use
mb_strtolower() instead.
84 Call to deprecated method strtolower() of class Drupal\Component\Utility\Unicode:
in Drupal 8.6.0, will be removed before Drupal 9.0.0. Use
mb_strtolower() instead.
93 Call to deprecated method strtolower() of class Drupal\Component\Utility\Unicode:
in Drupal 8.6.0, will be removed before Drupal 9.0.0. Use
mb_strtolower() instead.
------ -----------------------------------------------------------------------------------
------ ---------------------------------------------------------------------------------------
Line src/Plugin/WebformElement/MobileNumber.php
------ ---------------------------------------------------------------------------------------
Class Drupal\webform\Plugin\WebformElementBase not found and could not be autoloaded.
------ ---------------------------------------------------------------------------------------
------ --------------------------------------------------------------------------
Line src/Tests/MobileNumberFieldTest.php
------ --------------------------------------------------------------------------
397 Call to deprecated method entityManager() of class Drupal:
in Drupal 8.0.0 and will be removed before Drupal 9.0.0.
Use \Drupal::entityTypeManager() instead in most cases. If the needed
method is not on \Drupal\Core\Entity\EntityTypeManagerInterface, see the
deprecated \Drupal\Core\Entity\EntityManager to find the
correct interface or service.
------ --------------------------------------------------------------------------
Comment | File | Size | Author |
---|---|---|---|
#9 | Screenshot 2019-09-30 at 3.38.15 PM.png | 18.84 KB | karan_mudi |
#9 | interdiff.txt | 9.61 KB | karan_mudi |
#6 | interdiff.txt | 3.63 KB | karan_mudi |
#6 | mobile-number-d9-compatibility-3075958-2.patch | 7.31 KB | karan_mudi |
| |||
#3 | 3075958-d9-compatibility-fixes.patch | 4.04 KB | karan_mudi |
|
Issue fork mobile_number-3075958
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
karan_mudi CreditAttribution: karan_mudi commentedComment #3
karan_mudi CreditAttribution: karan_mudi commentedAttached patch for above issues.
Comment #4
karan_mudi CreditAttribution: karan_mudi as a volunteer commentedComment #5
amitgoyal CreditAttribution: amitgoyal commentedBefore applying the patch, I was getting 20 deprecation errors. The patch has fixed around 10 deprecation errors but still seeing following deprecations,
Comment #6
karan_mudi CreditAttribution: karan_mudi as a volunteer commentedRedone the patch with all the deprecation fixes, Please review.
Comment #7
karan_mudi CreditAttribution: karan_mudi as a volunteer commentedComment #8
amitgoyal CreditAttribution: amitgoyal commentedI am getting following error with #7,
Looks like we need to add following in src/Plugin/TfaValidation/MobileNumberTfa.php,
Comment #9
karan_mudi CreditAttribution: karan_mudi as a volunteer commentedRedone the patch with all the deprecation fixes, Please review.
The issue which has mentioned in https://www.drupal.org/project/mobile_number/issues/3075958#comment-1326... is showing because tfa module was installed, Once we installed this module related classes will be available.
Comment #10
karan_mudi CreditAttribution: karan_mudi as a volunteer commentedRedone the patch with all the deprecation fixes, Please review.
Comment #11
amitgoyal CreditAttribution: amitgoyal commentedEarlier I was getting 20 errors but applying the #10 patch, most of the errors have gone.
We believe those are related to third party dependencies.
Comment #12
maxilein CreditAttribution: maxilein commentedAny updates on this?
Comment #15
karan_mudi CreditAttribution: karan_mudi as a volunteer commentedNew patch to support 8.x-1.0-alpha5 module.
Comment #16
dwkitchen CreditAttribution: dwkitchen at Centarro commentedA patch from the MR can be downloaded from https://git.drupalcode.org/project/mobile_number/-/merge_requests/1.diff
Comment #18
nyariv CreditAttribution: nyariv commented@dwkitchen, thanks for the patch, it has been merged. Closing issue.