Problem/Motivation
The Scaffold plugin currently resides in core/lib/Drupal/Component
, where it is subtree-split out into its own component. In this configuration, when used by a Composer-based Drupal site, the code for the scaffold component would exist in the project in two locations: inside vendor, where it is actually run from, and also inside core/lib/Drupal/Component
, its unused source location.
Proposed resolution
To avoid this unnecessary duplication of code, it was decided to relocate the Composer plugins out of the core
directory and instead put them in composer/Plugin
, so that they do not become part of the drupal/core
subtree split.
This location is already being used in the most recent patch in #3057094: Add Composer vendor/ hardening plugin to core.
Remaining tasks
None.
Follow-on Tasks
None.
User interface changes
None.
API changes
None.
Data model changes
None.
Release notes snippet
n/a
Comment | File | Size | Author |
---|---|---|---|
#5 | 3076234-5.patch | 80.94 KB | greg.1.anderson |
#5 | 3076234-2-to-5.interdiff.txt | 711 bytes | greg.1.anderson |
#2 | 3076234-2.patch | 81.28 KB | greg.1.anderson |
Comments
Comment #2
greg.1.anderson CreditAttribution: greg.1.anderson at Pantheon commentedPatch with a failing test, to ensure that relocated tests are still running.
Comment #3
greg.1.anderson CreditAttribution: greg.1.anderson at Pantheon commentedSet status to run the tests.
Comment #5
greg.1.anderson CreditAttribution: greg.1.anderson at Pantheon commentedSame thing, but without the failing test.
Comment #6
Mile23Checked that all the files were moved, and got a passing test run from:
RTBC, man.
Comment #7
larowlanI tested that files in this folder could not be accessed via the browser, and confirmed they were access denied.
Committed 3a4092e and pushed to 8.8.x. Thanks!