4/4 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

------ -----------------------------------------------------------------------
Line src/Form/CKEditorEntityLinkConfigForm.php
------ -----------------------------------------------------------------------
71 Call to deprecated method entityManager() of class Drupal:
in Drupal 8.0.0 and will be removed before Drupal 9.0.0.
Use \Drupal::entityTypeManager() instead in most cases. If the needed
method is not on \Drupal\Core\Entity\EntityTypeManagerInterface, see
the
deprecated \Drupal\Core\Entity\EntityManager to find the
correct interface or service.
------ -----------------------------------------------------------------------

------ -----------------------------------------------------------------------
Line src/Form/CKEditorEntityLinkDialog.php
------ -----------------------------------------------------------------------
129 Call to deprecated method entityManager() of class Drupal:
in Drupal 8.0.0 and will be removed before Drupal 9.0.0.
Use \Drupal::entityTypeManager() instead in most cases. If the needed
method is not on \Drupal\Core\Entity\EntityTypeManagerInterface, see
the
deprecated \Drupal\Core\Entity\EntityManager to find the
correct interface or service.
161 Call to deprecated method url() of class
Drupal\Core\Entity\EntityInterface:
in Drupal 8.0.0, intended to be removed in Drupal 9.0.0
Please use toUrl() instead.
------ -----------------------------------------------------------------------

[ERROR] Found 3 errors

CommentFileSizeAuthor
#7 ckeditor_entity_link-3076917-7.patch467 bytesmrinalini9
#2 ckeditor_entity_link-3076917-2.patch1.66 KBjoy29
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joy29 created an issue. See original summary.

joy29’s picture

joy29 CreditAttribution: joy29 at Srijan | A Material+ Company commented
FileSize
ckeditor_entity_link-3076917-2.patch1.66 KB

drupal 9 deprecated method removed

joy29’s picture

joy29 CreditAttribution: joy29 at Srijan | A Material+ Company commented
Assigned: joy29 » Unassigned
Status: Active » Needs review
dmitry.korhov’s picture

dmitry.korhov
Primary language English
Location Poland, Warsaw
CreditAttribution: dmitry.korhov at EPAM Systems commented
Status: Needs review » Reviewed & tested by the community

Patch looks good, marked as reviewed

dmitry.korhov’s picture

dmitry.korhov
Primary language English
Location Poland, Warsaw
CreditAttribution: dmitry.korhov at EPAM Systems commented
Issue tags: +Drupal 9 porting weekend, +epam-contrib
dealancer’s picture

dealancer CreditAttribution: dealancer commented
Status: Reviewed & tested by the community » Needs work

Patch failed:

patching file src/Form/CKEditorEntityLinkConfigForm.php
Hunk #1 FAILED at 68.
1 out of 1 hunk FAILED -- saving rejects to file src/Form/CKEditorEntityLinkConfigForm.php.rej
patching file src/Form/CKEditorEntityLinkDialog.php
Hunk #1 FAILED at 126.
Hunk #2 succeeded at 183 with fuzz 2 (offset 25 lines).
1 out of 2 hunks FAILED -- saving rejects to file src/Form/CKEditorEntityLinkDialog.php.rej
mrinalini9’s picture

mrinalini9 CreditAttribution: mrinalini9 at Srijan | A Material+ Company for Drupal India Association commented
Status: Needs work » Needs review
FileSize
ckeditor_entity_link-3076917-7.patch467 bytes

Rerolled patch #2, please review. (And also, other changes in the patch #2 seems already present in the branch 8.x-1.x).

Simon Georges’s picture

Simon Georges CreditAttribution: Simon Georges at Makina Corpus commented

This patch has allowed us to have the module working on a D9 installation, thanks!

Simon Georges’s picture

Simon Georges CreditAttribution: Simon Georges at Makina Corpus commented
Priority: Normal » Major

I am bumping the priority, since the module indicates it is compatible to Drupal 9, but actually is not.

  • dealancer committed f1c980c on 8.x-1.x authored by mrinalini9 
    Issue #3076917 by joy29, mrinalini9: Drupal 9 Deprecated Code Report
dealancer’s picture

dealancer CreditAttribution: dealancer commented
Status: Needs review » Fixed

@Simon Georges, good job. thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.