[D8] Page Maintenance Mode

Thank you for the contribution!

Added a Pareview link into the issue summary.

1. Bad line endings were found, always use unix style terminators.

./page_maintenance_mode.info.yml: ASCII text, with CRLF line terminators
./config/install/page_maintenance_mode.settings.yml: ASCII text, with CRLF line terminators
./page_maintenance_mode.permissions.yml: ASCII text, with CRLF line terminators
config/install/page_maintenance_mode.settings.yml
page_maintenance_mode.info.yml
page_maintenance_mode.permissions.yml

2. Coder Sniffer has found some issues with your code.

FILE: .../vendor/drupal/pareviewsh/pareview_temp/page_maintenance_mode.module
--------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
--------------------------------------------------------------------------
72 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found
| | 12
74 | ERROR | [x] Expected one space after the comma, 0 found
75 | WARNING | [x] A comma should follow the last multiline array item.
| | Found:
| | 'https://www.drupal.org/project/page_maintenance_mode'
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

3. DrupalPractice has found some issues with your code.

FILE: ...areviewsh/pareview_temp/src/Form/PageMaintenanceModeSettingsForm.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 10 WARNINGS AFFECTING 10 LINES
--------------------------------------------------------------------------
77 | WARNING | t() calls should be avoided in classes, use dependency
| | injection and $this->t() instead
81 | WARNING | t() calls should be avoided in classes, use dependency
| | injection and $this->t() instead
82 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
87 | WARNING | t() calls should be avoided in classes, use dependency
| | injection and $this->t() instead
89 | WARNING | t() calls should be avoided in classes, use dependency
| | injection and $this->t() instead
94 | WARNING | t() calls should be avoided in classes, use dependency
| | injection and $this->t() instead
95 | WARNING | t() calls should be avoided in classes, use dependency
| | injection and $this->t() instead
116 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
122 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
139 | WARNING | \Drupal calls should be avoided in classes, use
| | dependency injection instead
--------------------------------------------------------------------------

Thanks for your contribution!

I was trying to test for XSS vulnerabilities but was not able to access the settings page: TypeError: Argument 4 passed to Drupal\page_maintenance_mode\Form\PageMaintenanceModeSettingsForm::__construct() must be an instance of Drupal\page_maintenance_mode\Form\AliasManagerInterface, instance of Drupal\Core\Path\AliasManager given. Can you clear that up and fix the use statements? Thanks!

Thanks for the contribution!

Please fix the following issues:

(1.)
Unknown AliasManagerInterface usage in __construct() method of class PageMaintenanceModeSettingsForm.
You maybe need to add one "use" statement more about.

(2.)

 ------ ---------------------------------------------------------------------------------
  Line   src\Form\PageMaintenanceModeSettingsForm.php
 ------ ---------------------------------------------------------------------------------
  40     Drupal\page_maintenance_mode\Form\PageMaintenanceModeSettingsForm::__construct() does not call parent constructor from Drupal\Core\Form\ConfigFormBase.
  40     Parameter $alias_manager of method Drupal\page_maintenance_mode\Form\PageMaintenanceModeSettingsForm::__construct() has invalid typehint type Drupal\page_maintenance_mode\Form\AliasManagerInterface.
 ------ ---------------------------------------------------------------------------------

@klausi Yes, it is. Both of us make a review separately with the same issue.

Sorry for the duplication. :)

Please fix the issue reported by Drupal Check:

 ------ --------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   src/Form/PageMaintenanceModeSettingsForm.php                                                                                                             
 ------ --------------------------------------------------------------------------------------------------------------------------------------------------------- 
  41     Drupal\page_maintenance_mode\Form\PageMaintenanceModeSettingsForm::__construct() does not call parent constructor from Drupal\Core\Form\ConfigFormBase.  
 ------ --------------------------------------------------------------------------------------------------------------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 1 error 

Thank you for fixing issues

1. Could you please remove empty else.

2. Could you please take a look this screenshot? Is there a wrong typing or something special in PHP?

$$entity_type_manager is correct PHP code, but in this case that is surely a typo for $entity_type_manager.

Thank you for the review, but we don't aim to point out every PHP errors/typos, except in cases such as the full file code being commented out, or the full code being outside functions/classes.

Hi @KuldeepM,

I've reviewed your module and it works well for me. Also, Pareview.sh doesn't report any errors now.

Thanks,
Subhadeep

Thank you for the contribution!

I have not found any security related issues into the code.

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.