Problem/Motivation

In #3067645: Add core scaffold assets to drupal/core's composer.json extra field, the composer.lock file was not updated. The result of this is that the Drupal scaffold file information was not copied into the composer.lock file currently on the 8.8.x branch.

Drupal currently is not using the Scaffold plugin with drupal/drupal; the scaffold plugin only comes into play when using drupal/core with a Composer-managed site. From a practical standpoint, anyway, it does not matter whether the information is there or not. It will be automatically added the next time any issue updates drupal/core's composer.json file for any other reason.

Proposed resolution

This patch updates composer.lock with the missing information in order to avoid potential confusion in other issues, where reviewers might wonder "why is this changing?"

Remaining tasks

None.

Follow-on Tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

Not needed.

CommentFileSizeAuthor
#4 Hyper 2019-08-30 01-26-59.png700.37 KBhussainweb
#2 3078058-2.patch3.46 KBgreg.1.anderson
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

greg.1.anderson created an issue. See original summary.

greg.1.anderson’s picture

greg.1.anderson CreditAttribution: greg.1.anderson at Pantheon commented
FileSize
3078058-2.patch3.46 KB

Note that this patch also updates the reference to the drupal/core-file-security component, which should have been part of #3013210: Add drupal/core-filesecurity component for writing htaccess files.

greg.1.anderson’s picture

greg.1.anderson CreditAttribution: greg.1.anderson at Pantheon commented
Status: Active » Needs review

Set the status so that the tests will run. :P

hussainweb’s picture

hussainweb
Primary language English
CreditAttribution: hussainweb at Axelerant commented
Status: Needs review » Reviewed & tested by the community
FileSize
Hyper 2019-08-30 01-26-59.png700.37 KB

This looks correct to me. I took a fresh pull of 8.8.x branch and ran composer update --lock and the markup is same as the patch.

In case it is not clear, the screenshot is not from the patch, but after running composer update --lock myself.

Changes after composer update --lock

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick at Acquia commented
Status: Reviewed & tested by the community » Fixed

Looks like a straight-forward follow-up. (#FamousLastWords :D)

Committed and pushed to 8.8.x. Thanks!

  • webchick committed 1b6d10d on 8.8.x 
    Issue #3078058 by greg.1.anderson, hussainweb: Update composer.lock with...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.