Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Git Deploy displays an error on the status page if the git binary is not present and executable. Since it cannot do anything without the git binary, it should not allow installation without being able to execute the git binary.
Comment | File | Size | Author |
---|---|---|---|
#9 | fix-installation-requirements-3079539-9.patch | 1.23 KB | Darren Oh |
Comments
Comment #2
Gábor HojtsyAt least for the purposes of Upgrade Status, we can disable the version checking feature if you don't allow exec or return an unknown version number. Git deploy could resolve that by itself anyway, as it needs some fallback for when it cannot work. So moving to that queue.
Comment #3
KlemenDEV CreditAttribution: KlemenDEV as a volunteer and at Pylo commentedAn option to at least disable (skip version checking) git would be a great start, I agree.
Comment #4
Gábor HojtsyWell, git deploy attempts to augment the project info from packages. If it cannot exec() it should "fail silently" at least when it works. I can produce a status report warning that it is uselessly installed, but it would need to deal with this itself IMHO. Modules depending it cannot really tell what is the internal architecture of the module.
Comment #5
Darren OhGit Deploy displays an error on the Drupal status page if it is installed on a site with exec disabled.
Comment #6
KlemenDEV CreditAttribution: KlemenDEV as a volunteer and at Pylo commentedIt displays error on Drupal status page, but modules such as upgrade_status fail to work if exec is disabled.
Comment #7
Darren OhGit Deploy should be uninstalled if exec is disabled.
Comment #8
Gábor HojtsyDisplaying an error on the status report page is not really helpful especially when using other projects that depend on git_deploy. Also uninstalling git_deploy in this case would not be useful for eg. upgrade_status which would also need to be uninstalled, even though it could do useful things without git_deploy, just not that useful. Git_deploy should by itself have a fail condition for when exec() is not enabled.
Comment #9
Darren OhGit Deploy should not be installed at all if git is not executable, because it cannot do anything. Projects that don’t require Git Deploy to work should not depend on it. Upgrade Status should implement its own message for the status page to notify admins of reduced functionality without Git Deploy.
I have provided a patch that clarifies the error message and prevents Git Deploy from being installed when the git binary is missing or not executable.
Comment #10
Gábor HojtsyComment #12
Gábor HojtsyThanks @Darren Oh! Worked further from your patch to include specific messaging as to what the problem is so people have an easier time to debug / fix.