Patch will be attached.

CommentFileSizeAuthor
#2 3080795-2.migrate_upgrade.migrationdetails-never-emptied.patch678 bytessuper_romeo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

super_romeo created an issue. See original summary.

super_romeo’s picture

super_romeo CreditAttribution: super_romeo commented
Status: Active » Needs review
FileSize
3080795-2.migrate_upgrade.migrationdetails-never-emptied.patch678 bytes
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented

For posterity, can we explain the implications and problems with not resetting $migration_details in the IS?

super_romeo’s picture

super_romeo CreditAttribution: super_romeo commented

Sure.
E.g. in this "foreach" there is:

if (isset($plugin_definition['field_plugin_method'])) {
  $migration_details['field_plugin_method'] = $plugin_definition['field_plugin_method'];
}

This "if" sets $migration_details element. And this element is wrongly used in next migration.
In my case, at the "field_instance"-migration ['field_plugin_method'] element is added. And it still wrongly exists till "user"-migration.

  • heddn committed de75e69 on 8.x-3.x authored by super_romeo 
    Issue #3080795 by super_romeo, heddn: $migration_details never emptied
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
Status: Needs review » Fixed

Thanks for your contributions and the follow-up note why...

super_romeo’s picture

super_romeo CreditAttribution: super_romeo commented

:) You are welcome.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.