The theming function /modules/facets_summary/templates/facets-summary.html.twig does not appear to be used.

We need to doublecheck if this is used anywhere, and if not, remove it

CommentFileSizeAuthor
#4 facets-remove_obsolete_code-3081071-4.patch1.45 KBaniketto
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

StryKaizer created an issue. See original summary.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ at Calibrate commented
Issue tags: +Novice

I agree, this is not used, it can be removed but there should be a change notice for this as well.

Tagging as novice,because it is basically removing 1 theme hook + 1 file & a small change notice.

aniketto’s picture

aniketto
Primary language Japanese
Location Tokyo
CreditAttribution: aniketto commented
Assigned: Unassigned » aniketto
aniketto’s picture

aniketto
Primary language Japanese
Location Tokyo
CreditAttribution: aniketto commented
Assigned: aniketto » Unassigned
Status: Active » Needs review
FileSize
facets-remove_obsolete_code-3081071-4.patch1.45 KB

Created patch as per the instructions in #2 and below change notice
https://www.drupal.org/node/3091353

Please validate.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ at Calibrate commented
Status: Needs review » Reviewed & tested by the community

This does what is supposed to, +1

  • Nick_vh committed 08d888e on 8.x-1.x authored by aniki47 
    Issue #3081071 by aniki47: Remove obsolete theming function
Nick_vh’s picture

Nick_vh
he/him
Location Ghent
CreditAttribution: Nick_vh at Dropsolid commented
Status: Reviewed & tested by the community » Fixed

committed and pushed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.