Problem/Motivation

The GoogleAnalitycsInterface gets loose in src

Proposed resolution

Create Constants folder, puts GoogleAnalitycsInterface there and updated the usages

CommentFileSizeAuthor
#2 google_analytics-Create_folder_constants_for_GoogleAnalitycsInterface-3083594-2-D8.patch1.05 KBthalles
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

thalles created an issue. See original summary.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
CreditAttribution: thalles at CI&T commented
Status: Needs work » Needs review
FileSize
google_analytics-Create_folder_constants_for_GoogleAnalitycsInterface-3083594-2-D8.patch1.05 KB

Follow the patch!

  • japerry committed 2d45a33 on 4.x 
    Issue #3083594 by japerry, thalles: Refactor GoogleAnalitycsInterface...
japerry’s picture

japerry
Location KVUO
CreditAttribution: japerry at Acquia commented
Version: 8.x-3.x-dev » 4.x-dev
Status: Needs review » Fixed

Good idea, I've done some refactoring of these classes and fixed in the 4.x version

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
CreditAttribution: thalles at CI&T commented

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.