Problem/Motivation

claro_preprocess_views_mini_pager() has a short-term fix for #3059232: Views mini pager Twig template has broken "aria-labelledby" reference. That's been fixed in core now.

Remaining tasks

Check if this is still needed in Claro, remove if not.

CommentFileSizeAuthor
#3 3083661-3.patch1.17 KBidebr
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andrewmacpherson created an issue. See original summary.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
CreditAttribution: huzooka at Cheppers for Acquia commented

At least we have to remove our preprocess, so we definitely need an action here.

Thanks for the report! (We missed the follow-up for this.)

idebr’s picture

idebr CreditAttribution: idebr at ezCompany commented
Status: Active » Needs review
FileSize
3083661-3.patch1.17 KB

Attached patch removes claro_preprocess_views_mini_pager() and updates the views-mini-pager.html.twig documentation.

fhaeberle’s picture

fhaeberle
he/him
Location 🇩🇪 Stuttgart
CreditAttribution: fhaeberle commented
Status: Needs review » Needs work

If I apply the patch, the mini pager doesn't get the heading ID.
What does possibly go wrong?
With the full pager it works and increments.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
CreditAttribution: huzooka at Cheppers for Acquia commented

Needs Drupal core version 8.8.x.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Version: 8.x-1.x-dev » 8.x-2.x-dev
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Status: Needs work » Needs review

@fhaeberle maybe you didn't have the most recent 8.8.x branch with the upstream fix?

Tested this manually with the latest 8.8.x and it works.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
CreditAttribution: huzooka at Cheppers for Acquia commented

I'm testing this.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
CreditAttribution: huzooka at Cheppers for Acquia commented
Status: Needs review » Reviewed & tested by the community

Got the same result as @lauriii wrote in #7.

Can be added in 8.x-2.x (this branch targets core 8.8.x and above).

RTBC!

  • lauriii committed da43a9f on 8.x-2.x 
    Issue #3083661 by idebr: Views mini-pager heading ID has been fixed...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Status: Reviewed & tested by the community » Fixed

Thank you all! 🙏Committed and pushed!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.