Class StatsDLogger.php and StatsdEventSubscriber.php contain \Drupal::service() to get the service. Please use the Dependency Injection to access the service.

CommentFileSizeAuthor
#3 dependency_injection-3083750.patch4.88 KBpratik_kamble
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pratik_kamble created an issue. See original summary.

pratik_kamble’s picture

pratik_kamble
Location Pune, India
CreditAttribution: pratik_kamble at QED42 commented

Working on fixing it.

pratik_kamble’s picture

pratik_kamble
Location Pune, India
CreditAttribution: pratik_kamble at QED42 commented
Status: Active » Needs review
FileSize
dependency_injection-3083750.patch4.88 KB

I have attached the patch to have dependency injection for Statsd Manager.

siddhant.bhosale’s picture

siddhant.bhosale CreditAttribution: siddhant.bhosale as a volunteer and at QED42 commented
Status: Needs review » Reviewed & tested by the community

I have reviewed and tested the patch and looks good to be merged.

  • pratik_kamble committed 06132d7 on 8.x-1.x 
    Issue #3083750 by pratik_kamble: Avoid use of \Drupal inside the classes
pratik_kamble’s picture

pratik_kamble
Location Pune, India
CreditAttribution: pratik_kamble at QED42 commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.