Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
media_library_update_8703() was added in #3039829: Remove link to media item from media library view.. After commit, @catch said that it should have been a post-update hook.
Proposed resolution
Since no hook_update_N's have been added to media_library since that issue, we can convert the update to a post-update. Let's do that. This does not need additional test coverage, as the update is already covered.
Remaining tasks
Do it.
User interface changes
None.
API changes
None.
Data model changes
None.
Release notes snippet
None.
Comment | File | Size | Author |
---|---|---|---|
#7 | interdiff-3084043-5-7.txt | 2.41 KB | phenaproxima |
#7 | 3084043-7.patch | 14.95 KB | phenaproxima |
#5 | 3084043-5.patch | 14.62 KB | phenaproxima |
#2 | 3084043-2.patch | 14.73 KB | phenaproxima |
Comments
Comment #2
phenaproximaComment #3
seanBTests are green!
Comment #4
alexpottPatch doesn't apply.
Comment #5
phenaproximaRerolled! Preemptively restoring RTBC on the assumption that tests will pass on all backends.
Comment #6
alexpottIf we do this we ned to change this comment as this appears in the UI. And it does not do that anymore.
If we doing a post update hook then we can use the full Views API and load the view here rather than do config manipulation. Which would one of the reasons to move this to a post update hook. I'm not sure why we'd just move the hook_update_N into a post update.
Comment #7
phenaproximaHow's this look?
Comment #8
Wim LeersComment #9
larowlanComment #10
larowlanCommitted 9cf1553 and pushed to 8.8.x. Thanks!
Comment #12
xjmAre either of these update functions valid following #2981105: Media Library should not modify the media view?
Comment #13
seanB@xjm I believe so, the changes to the media library view in this issue are useful and needed, regardless of #2981105: Media Library should not modify the media view. They do separate things.