We are still missing comments and are also not abiding by all Drupal coding standards. After we roll in #3061958: Variation set config is not deleted if its containing block is deleted, I'd like to correct this and enforce strict rules going forward.

Additionally, #3084110: Setup automated tests will help us catch bad code.

CommentFileSizeAuthor
#7 3084111-7.patch147.29 KBmichaellander
#6 3084111-6.patch145.44 KBmichaellander
#5 3084111-5.patch145.29 KBmichaellander
#4 3084111-4.patch139.67 KBmichaellander
#3 3084111-3.patch140.48 KBmichaellander
#2 3084111-2.patch91.04 KBmichaellander
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

michaellander created an issue. See original summary.

michaellander’s picture

michaellander CreditAttribution: michaellander at Elevated Third commented
FileSize
3084111-2.patch91.04 KB
michaellander’s picture

michaellander CreditAttribution: michaellander at Elevated Third commented
FileSize
3084111-3.patch140.48 KB

Uploading current progress.

michaellander’s picture

michaellander CreditAttribution: michaellander at Elevated Third commented
FileSize
3084111-4.patch139.67 KB
michaellander’s picture

michaellander CreditAttribution: michaellander at Elevated Third commented
FileSize
3084111-5.patch145.29 KB
michaellander’s picture

michaellander CreditAttribution: michaellander at Elevated Third commented
FileSize
3084111-6.patch145.44 KB
michaellander’s picture

michaellander CreditAttribution: michaellander at Elevated Third commented
FileSize
3084111-7.patch147.29 KB

  • michaellander committed 0e17067 on 8.x-1.x 
    Issue #3084111 by michaellander: Code cleanup and comments
michaellander’s picture

michaellander CreditAttribution: michaellander at Elevated Third commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.