$ drupal-check -ad web/modules/devel_debug_log

 6/6 [============================] 100%

 ------ -------------------------------------------------------------------------
  Line   devel_debug_log.module
 ------ -------------------------------------------------------------------------
  37     Variable $message in isset() always exists and is not nullable.
  58     Variable $message_history in isset() always exists and is not nullable.
  104    Access to constant MODE_RICH on an unknown class Kint.
  104    Call to static method enabled() on an unknown class Kint.
  105    Call to static method dump() on an unknown class Kint.
 ------ -------------------------------------------------------------------------

 ------ ----------------------------------------------------------------------
  Line   src\Form\DevelDebugLogDeleteForm.php
 ------ ----------------------------------------------------------------------
  43     Call to deprecated function drupal_set_message():
         in Drupal 8.5.0 and will be removed before Drupal 9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
 ------ ----------------------------------------------------------------------

 ------ --------------------------------------------------------------------------------------
  Line   src\Twig\DevelDebugLogExtension.php
 ------ --------------------------------------------------------------------------------------
  51     Call to an undefined method Drupal\devel_debug_log\Twig\DevelDebugLogExtension::t().
 ------ --------------------------------------------------------------------------------------

 [ERROR] Found 7 errors
CommentFileSizeAuthor
#5 3084266-5.patch1.48 KBvuil
#2 3084266-2.patch1.84 KBvuil
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ilchovuchkov created an issue. See original summary.

vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at Bulpros Consulting commented
Status: Active » Needs review
FileSize
3084266-2.patch1.84 KB

Add it as a patch to test.

vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at Bulpros Consulting commented
Status: Needs review » Needs work

The patch #2 is applied (committed):

 ------ -----------------------------------------------------------
  Line   devel_debug_log.module
 ------ -----------------------------------------------------------
  100    Access to constant MODE_RICH on an unknown class Kint.
  100    Call to static method enabled() on an unknown class Kint.
  101    Call to static method dump() on an unknown class Kint.
 ------ -----------------------------------------------------------

 ------ ------------------------------------------------------------------------------
  Line   src\Form\DevelDebugLogDeleteForm.php
 ------ ------------------------------------------------------------------------------
  43     \Drupal calls should be avoided in classes, use dependency injection instead
 ------ ------------------------------------------------------------------------------

 [ERROR] Found 4 errors
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at Bulpros Consulting commented
Status: Needs work » Needs review
FileSize
3084266-5.patch1.48 KB

Patch for the following part:

 ------ ------------------------------------------------------------------------------
  Line   src\Form\DevelDebugLogDeleteForm.php
 ------ ------------------------------------------------------------------------------
  43     \Drupal calls should be avoided in classes, use dependency injection instead
 ------ ------------------------------------------------------------------------------
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at Bulpros Consulting commented

Hide committed patch #2.

  • ilchovuchkov committed 580fb8c on 8.x-1.x 
    Issue #3084266 by ilchovuchkov: Replace \Drupal::messenger() with DI.
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at Bulpros Consulting commented
Status: Needs review » Needs work

Applied (committed) patch #5:
Replace \Drupal::messenger() with DI.

Set to Needs work for the latest part:

 ------ -----------------------------------------------------------
  Line   devel_debug_log.module
 ------ -----------------------------------------------------------
  100    Access to constant MODE_RICH on an unknown class Kint.
  100    Call to static method enabled() on an unknown class Kint.
  101    Call to static method dump() on an unknown class Kint.
 ------ -----------------------------------------------------------
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at Bulpros Consulting commented

Hide the patch from #5 because it is already on 8.x-1.x (dev) branch.

  • ilchovuchkov committed 2f84a3e on 8.x-1.x 
    Issue #3084266 by ilchovuchkov: Add a comment into module.
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at Bulpros Consulting commented
Status: Needs work » Fixed 
 6/6 [============================] 100%

 [OK] No errors

Set the issue to Fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at FFW commented
Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Hook 42 commented
Issue tags: +Drupal 9 compatibility

Per a Slack discussion with Gábor Hojtsy regarding usage of D9 tags (Drupal 9, Drupal 9 compatibility, Drupal 9 readiness, etc.), "Drupal 9 compatibility" should be used for contributed projects that need updating and "Drupal 9" was the old tag for D8 issues before the D9 branch was ready. Doing tag cleanup here based on that discussion.