Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Right now the module load all medias with file type and then, all medias objects are pass to the batch so, this is wrong solution. Additional I can see warning in drupal log.
Deprecated function: Non-static method Drupal\media_pdf_thumbnail\Form\SettingsForm::regenerateThumbnails() should not be called statically w _batch_process()
Proposed resolution
You should load every single media entity with one batch step to work it correctly.
Comment | File | Size | Author |
---|---|---|---|
#2 | media_pdf_thumbnail-3085186-2.patch | 4.38 KB | lamp5 |
Comments
Comment #2
lamp5Patch attached. Also fixed warning and applied drupal coding standards.
Comment #3
sgostanyan CreditAttribution: sgostanyan as a volunteer and commentedThanks for the patch. Please update to version 2.1, several fix and code refactoring have been made.
Comment #4
sgostanyan CreditAttribution: sgostanyan as a volunteer and commentedComment #5
lamp5Please do not close issues which are fixed, these will be automatically closed after 2 weeks without activity. During these 2 weeks, we can check that everything working good.