Hello all, it’s time for the weekly migration initiative meeting. The meeting will take place in slack in various threads
This meeting:
➤ Is for core migrate maintainers and developers and anybody else in the community with an interest in migrations
➤ Usually happens every Thursday and alternates between 1400 and 2100 UTC.
➤ Is done over chat.
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to here.
➤*Transcript will be exported and posted* to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.
0️⃣ Who is here today? Give your name and favorite WCAG 2.1 guideline.
mikelutz | Mike. Migration maintainer, and I like the 1.2.4 AA guideline regarding Captions for live audio content. |
Nick Dickinson Wilde | Nick, he/him, Victoria BC :flag-ca: /T'So-uke Lands. Constant migration API user. WCAG 2.1 rule: 1.4.3 (AA) text and images of text has a contrast ratio of at least 4.5:1 |
damienmckenna | Damien, he/him, NH. Haven't looked at 2.1 yet. |
wimleers (he/him) | Wim, :flag-be:, impressed with the nerdy question (edited) |
1️⃣ What do we need to talk about? We will discuss all the NR issues int the migrate queue. What else?
2️⃣ I’m starting an official list of people to flag with @mentions before a migration meeting. Until now, I’ve just been going off the cuff flagging people that have been active recently. Let me know in this thread if you want to be alerted for the meeting each week.
Nick Dickinson Wilde | oh sure, HMU :slightly_smiling_face: |
mikelutz | Your name is too long right now. :stuck_out_tongue: |
damienmckenna | Works for me, ty for the inclusion. |
benjifisher | I am busy at BADCamp today, but please keep me on the list. Thanks! |
Nick Dickinson Wilde | My name is always too long. Regularly get's cut off on official documents - driver's licences, passports etc.Nicholas Wesley Benjamin van Ginkel Wilde |
heddn | heddn |
mikelutz | @heddn you are already on the list.. whether you want to be or not.. :stuck_out_tongue: |
3️⃣ Hide and disable Drupal Migrate Multilingual
mikelutz | #2966856: Hide and disable Drupal Migrate Multilingual |
4️⃣ Menu language not properly migrated from D7 localized menu links.
mikelutz | #3013625: Menu language not properly migrated from D7 localized menu links. |
quietone | I wish I could find time to properly look at this and in relation to the other i18 menu issue. |
5️⃣ Migrate D7 i18n taxonomy term field translations
mikelutz | #3073050: Migrate D7 i18n taxonomy term field translations |
quietone | Please review and/or test! |
6️⃣ Add checkrequirements to VariableTranslation source plugin
mikelutz | #3081123: Add checkrequirements to VariableTranslation source plugin |
quietone | Wrong comment, set back to NW |
7️⃣ Create Migration Lookup and Stub services
mikelutz | #3004927: Create Migration Lookup and Stub services |
mikelutz | I’m happy with this, but the more I think about it, the more I think we need to have a lookupByTag method on the lookup service. (edited) |
mikelutz | Or, alternatively, we might want to override the service in migrate_upgrade. |
mikelutz | My concern is that anywhere we use this in core, we are using migration_ids that migrate_upgrade is going to change. I don’t want to block this on it, but I want things to work with contrib too. |
quietone | please say more about lookupByTag. (I've stayed awake and not thinking too clearly) |
mikelutz | I’ve always thought it would be useful to do a migration lookup by tag, both in core and in custom migrations. Specifically because of the way that migrate_upgrade changes migration ids and breaks derivative migrations. migrate upgrade can handle changing ‘d7_node’ into ‘upgrade_d7_node_page, upgrade_d7_node_article’ on a migration lookup plugin, but it won’t be able to do it in this service. If we tagged the d7_node migrations as such, we could lookup by tag, and we would lookup against all the derivitives no matter how contrib renames them. |
mikelutz | But, alternatively, it might be migrate_upgrade’s responsibility to override the service, and somehow keep track of the id mappings and manage it too. |
mikelutz | Either way, I’m just mentioning it as something to manage in a follow up. |
quietone | thx |
mikelutz | @heddn Would love to get this back to RTBC |
8️⃣ migrate_drupal_migration_plugins_alter should only alter definitions that exist
mikelutz | #3082719: migrate_drupal_migration_plugins_alter() should only alter definitions that exist |
quietone | this one should be an easy review |
Nick Dickinson Wilde | makes sense to me |
quietone | thx and I've posted a patch fixing the typo |
mikelutz | Test looks good and thorough, I might have just gone with a unit test and mocked the module handler, but this is better. |
9️⃣ Convert path alias migrations to use entity:path_alias destination
mikelutz | #3009014: Convert path alias migrations to use entity:path_alias destination |
1️⃣ 0️⃣ Migrate D6 and D7 node revision translations to D8 (edited)
mikelutz | #2746541: Migrate D6 and D7 node revision translations to D8 |
mikelutz | This one is pretty critical, a blocker to drupal 9 beta, and something we would like to get in before 8.8 beta as well. |
quietone | Definitely needs reviews/input despite failing tests. |
mikelutz | I’ve been monitoring, I need to find more time for it, I’ve got several other issues that need to be in by alpha that have been taking my time this week. |
mikelutz | The lookup and stub services being one of them. |
mikelutz | And the path alias migration. |
quietone | I know, lots happening at once. |
quietone | I don't like all the altering going on in the patch but don't see another way. |
quietone | In the related entity translation issue one of the revision is saved with the changed time of now() and not the migrated value. Any suggestions on why that happens? |
mikelutz | That usually happens when the node is saved a second time. The entity api sees the changed timestamp matches the one in the database so it thinks it needs to be updated. There’s no workaround in the entity api at the moment that I know of. |
quietone | thx, something for me to check after I get some rest |
mikelutz | Get some sleep, but RTBC #3009014: Convert path alias migrations to use entity:path_alias destination first!! :slightly_smiling_face: |
quietone | It will be better for all of us if I do that after I get some sleep. |
mikelutz | Goodnight, @quietone go to :sleeping_accommodation: :parrotsleep: |
1️⃣ :one: That concludes the meeting, please feel free to continue the discussion in the threads above. See you next week! (edited)
Participants:
alison, mikelutz, Nick Dickinson Wilde, damienmckenna, wimleers (he/him), benjifisher, heddn, quietone
Comments
Comment #4
quietone CreditAttribution: quietone as a volunteer commentedComment #8
quietone CreditAttribution: quietone as a volunteer commentedComment #9
quietone CreditAttribution: quietone as a volunteer commentedComment #12
quietone CreditAttribution: quietone as a volunteer commentedComment #13
quietone CreditAttribution: quietone as a volunteer commentedComment #15
quietone CreditAttribution: quietone as a volunteer commentedComment #16
quietone CreditAttribution: quietone as a volunteer commentedComment #19
quietone CreditAttribution: quietone as a volunteer commentedOn Slack, alison told me that her d.o name is alisonjo315 not alison. So, I am correcting the credit.