php drupal-check.phar modules/contrib/menu_link_weight/
 14/14 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ---------------------------------------------- 
  Line   menu_link_weight.node.inc                     
 ------ ---------------------------------------------- 
  130    Call to deprecated function drupal_render().  
  131    Call to deprecated function drupal_render().  
 ------ ---------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/src/FunctionalJavascript/MenuLinkWeightJavascriptTestBase.php                                                                                                      
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  16     Class Drupal\Tests\menu_link_weight\FunctionalJavascript\MenuLinkWeightJavascriptTestBase extends deprecated class Drupal\FunctionalJavascriptTests\JavascriptTestBase.  
  71     Call to method setUp() of deprecated class Drupal\Tests\BrowserTestBase.                                                                                                 
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 4 errors
CommentFileSizeAuthor
#9 3086197-9.patch1010 bytesjohnwebdev
#5 3086197-5.patch1.96 KBjohnwebdev
#5 interdiff_3-5.txt697 bytesjohnwebdev
#3 3086197-3.patch1.79 KBjohnwebdev
#2 deprecated-3086197-2.patch1.86 KBSergiu Stici
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Sergiu Stici created an issue. See original summary.

Sergiu Stici’s picture

Sergiu Stici CreditAttribution: Sergiu Stici at FFW commented
Status: Active » Needs review
FileSize
deprecated-3086197-2.patch1.86 KB

Here is the patch, please review.

johnwebdev’s picture

johnwebdev CreditAttribution: johnwebdev commented
FileSize
3086197-3.patch1.79 KB

Patch in #2 looks right, but CI says something else. Let's try it again.

johnwebdev’s picture

johnwebdev CreditAttribution: johnwebdev commented

Ahh, it shouldn't run on PHP 5.5. I've updated the defaults for the automated testing settings.

johnwebdev’s picture

johnwebdev CreditAttribution: johnwebdev commented
FileSize
interdiff_3-5.txt697 bytes
3086197-5.patch1.96 KB

Let's try use the legacy PhantomJS approach and make a follow up to convert to DrupalSelenium2Driver driver.

johnwebdev’s picture

johnwebdev CreditAttribution: johnwebdev commented
Status: Needs review » Needs work

Actually, we should probably not do that. I misinterpreted the change record, PhantomJS will be removed in 9.0.0 as well. #3088688: Remove PhantomJS based testing

johnwebdev’s picture

johnwebdev CreditAttribution: johnwebdev commented
Status: Needs work » Postponed

So the problem here is that the Selenium driver does not allow you manipulate values that are hidden, which makes these tests very hard to pass. I'm going to postpone this on a new issue that rewrites the tests, separating JavaScript with basic functional ones.

See #3099697: Refactor tests

johnwebdev’s picture

johnwebdev CreditAttribution: johnwebdev commented
Status: Postponed » Needs work

Blocker has been committed.

johnwebdev’s picture

johnwebdev CreditAttribution: johnwebdev commented
Status: Needs work » Needs review
FileSize
3086197-9.patch1010 bytes
johnzzon’s picture

johnzzon
Primary language Swedish
Location Gothenburg 🇸🇪
CreditAttribution: johnzzon at Kodamera AB commented
Status: Needs review » Reviewed & tested by the community

Looks great.

  • johndevman committed ecc8d1f on 8.x-1.x 
    Issue #3086197 by johndevman, Sergiu Stici, johnzzon: Deprecated Code...
johnwebdev’s picture

johnwebdev CreditAttribution: johnwebdev at Kodamera AB commented
Status: Reviewed & tested by the community » Fixed

Deprecations are removed. We can make it actual installable for Drupal 9 in a separate issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.