Problem/Motivation

Disabled and empty boolean input styles (checkbox, radio) do not follow the designs anymore:

The empty input of a checkbox and even an emtpy radio shows a white checkbox.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#5 3086264-5.claro_.Regression-Disabled-and-empty-boolean-input-styles-checkbox-radio-do-not-follow-the-designs-anymore.patch1.05 KBfhaeberle
#3 3086264-3.claro_.Regression-Disabled-and-empty-boolean-input-styles-checkbox-radio-do-not-follow-the-designs-anymore.patch12.87 KBfhaeberle
Claro--empty-checkbox-radio.png500.08 KBhuzooka
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
CreditAttribution: huzooka at Cheppers for Acquia commented

huzooka created an issue. See original summary.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
CreditAttribution: huzooka at Cheppers for Acquia commented
Issue tags: +beta blocker
fhaeberle’s picture

fhaeberle
he/him
Location 🇩🇪 Stuttgart
CreditAttribution: fhaeberle commented
Status: Active » Needs review
Related issues: +#3024975: Add Drupal JavaScript theme function for checkbox
FileSize
3086264-3.claro_.Regression-Disabled-and-empty-boolean-input-styles-checkbox-radio-do-not-follow-the-designs-anymore.patch12.87 KB

This is actually a pretty small change with adding "background-image: none" to the disabled checkbox and radios but I recognized that we still have the workarounds for Add Drupal JavaScript theme function for checkbox in place so I removed them also. Hopefully this fixes the problem and cleans the codebase a bit up.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Status: Needs review » Needs work

@fhaeberle We're doing the code removal part here #3024996: Remove tableselect.js and media_library.view.js overrides 🙂

fhaeberle’s picture

fhaeberle
he/him
Location 🇩🇪 Stuttgart
CreditAttribution: fhaeberle commented
Status: Needs work » Needs review
FileSize
3086264-5.claro_.Regression-Disabled-and-empty-boolean-input-styles-checkbox-radio-do-not-follow-the-designs-anymore.patch1.05 KB

Uh didn't see that one! Updated my patch 🔁
Leaving the interdiff. 😅

  • lauriii committed f003d9d on 8.x-2.x 
    Issue #3086264 by fhaeberle, huzooka: [Regression] Disabled and empty...

  • lauriii committed 7abaa82 on 8.x-1.x 
    Issue #3086264 by fhaeberle, huzooka: [Regression] Disabled and empty...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented
Status: Needs review » Fixed

Good catch, and thank you @fhaeberle for fixing this!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.