Problem/Motivation

Path aliases have been converted to entities in Drupal 8.8: https://www.drupal.org/node/3013865

Since, the path alias forms will also be converted to entity forms in #3007832: Convert custom path alias forms to entity forms, this module will need a few adjustments to in order to keep it working with the latest Drupal minor version.

Proposed resolution

Figure out what changes are needed, preferably in a way that keeps the module compatible with Drupal 8.7 and below as well.

Remaining tasks

TBD.

User interface changes

Nope.

API changes

TBD.

Data model changes

TBD.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

amateescu created an issue. See original summary.

manuel.adan’s picture

Status: Active » Postponed

Thanks for notifying!

I've been following #2336597: Convert path aliases to full featured entities, I tested the module against the latest D8.8 dev right once it was committed. As the fixed_path_alias module operates by decorating the path alias manager, the changes do not affect its functionality.

About #3007832: Convert custom path alias forms to entity forms, I still didn't any test, I prefer to wait for the CR to be published.

manuel.adan’s picture

Status: Postponed » Needs review
FileSize
4.21 KB

#3007832: Convert custom path alias forms to entity forms was committed just a few minutes after I sent my previous comment. This is a quick minimal first approach that makes the module aware of the path aliases changes introduced in the Drupal 8.8 branch, without breaking compatibility with previous versions. An entire module review/refactoring is pending, but the module usage is still low and, as every body, I run short of time.

manuel.adan’s picture

Introduced changes makes the module compatible only with D8.8+ versions. A 2.x branch should be needed only if a new release of the module were launched within the D8.7 maintenance period.

manuel.adan’s picture

ralphvdhoudt’s picture

Patch that can be used against beta1 and issue #3013926

ralphvdhoudt’s picture

Patch that can be used against beta1 zip file and issue #3013926

manuel.adan’s picture

Now than D8.7 is officially unsupported we can safely remove any code that ensures compatibility with D < 8.8, gaining compatibility with D9 by the way. Old path alias hook implementations has been replaced by their entity based equivalent. Interdiff fails due changes in base code.

  • manuel.adan committed 9946915 on 8.x-1.x
    Issue #3086814 by manuel.adan, ralphvdhoudt: Prepare for the path alias...
manuel.adan’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.