Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The module Video Embed Peertube adds a new provider for Peertube videos for "video embed field" module.
Project link
https://www.drupal.org/project/video_embed_peertube
Git instructions
git clone --branch 8.x-1.x https://git.drupalcode.org/project/video_embed_peertube.git
PAReview checklist
https://pareview.sh/pareview/https-git.drupal.org-project-video_embed_pe...
Comments
Comment #2
apadernoThank you for applying! Remember to change status, when the project is ready to be reviewed. The current status is telling users not to review it.
Comment #3
phjouThanks for the catch, sorry about that.
Comment #4
vuilThank you for the contribution!
I did not find a security issue in the project code.
Comment #5
phjouThanks for your review @vuil
Comment #6
apadernoOnly reviewers can set the status to Reviewed & tested by the community.
Comment #7
apadernoComment #8
phthlaap CreditAttribution: phthlaap as a volunteer and commentedThanks for your contribution.
Please fix this issue:
Comment #9
phjou@phthlaap Could you please tell how did you get that error?
The module has video_embed_field as a dependency and when I use composer require the module is added correctly with his dependencies.
The class Drupal\video_embed_field\ProviderPluginBase has not been deleted by video_embed_field and is correctly there.
I checked in the logs and nothing shows up. Could you provide the exact steps to reproduce?
Comment #10
phthlaap CreditAttribution: phthlaap as a volunteer and commentedThanks for your contribution. I have not found any security issues related to the code.
Comment #11
apadernoI don't see anything wrong in the code that would explain why the other module is not found. The composer.json file uses ^2.0 as costrain, and that allow any version that is higher or equal to 2.0 and lower than 3.0.
If this issue were reproducible, it would eventually be a bug, not something we expect to fix on these applications.
Comment #12
apadernoThank you for your contribution! I am going to update the project.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.
Comment #13
vuilI added my employer only.
Comment #14
apaderno