The module Video Embed Peertube adds a new provider for Peertube videos for "video embed field" module.

Project link

https://www.drupal.org/project/video_embed_peertube

Git instructions

git clone --branch 8.x-1.x https://git.drupalcode.org/project/video_embed_peertube.git

PAReview checklist

https://pareview.sh/pareview/https-git.drupal.org-project-video_embed_pe...

Comments

phjou created an issue. See original summary.

apaderno’s picture

Thank you for applying! Remember to change status, when the project is ready to be reviewed. The current status is telling users not to review it.

phjou’s picture

Status: Active » Needs review

Thanks for the catch, sorry about that.

vuil’s picture

Thank you for the contribution!

I did not find a security issue in the project code.

phjou’s picture

Status: Needs review » Reviewed & tested by the community

Thanks for your review @vuil

apaderno’s picture

Status: Reviewed & tested by the community » Needs review

Only reviewers can set the status to Reviewed & tested by the community.

apaderno’s picture

phthlaap’s picture

Status: Needs review » Needs work

Thanks for your contribution.

Please fix this issue:

 ------ ------------------------------------------------------------------------------------------ 
  Line   src/Plugin/video_embed_field/Provider/Peertube.php                                        
 ------ ------------------------------------------------------------------------------------------ 
         Class Drupal\video_embed_field\ProviderPluginBase not found and could not be autoloaded.  
 ------ ------------------------------------------------------------------------------------------ 

                                                                                                                        
 [ERROR] Found 1 error
phjou’s picture

Status: Needs work » Needs review

@phthlaap Could you please tell how did you get that error?

The module has video_embed_field as a dependency and when I use composer require the module is added correctly with his dependencies.
The class Drupal\video_embed_field\ProviderPluginBase has not been deleted by video_embed_field and is correctly there.

I checked in the logs and nothing shows up. Could you provide the exact steps to reproduce?

phthlaap’s picture

Status: Needs review » Reviewed & tested by the community

Thanks for your contribution. I have not found any security issues related to the code.

apaderno’s picture

Status: Reviewed & tested by the community » Needs review

I don't see anything wrong in the code that would explain why the other module is not found. The composer.json file uses ^2.0 as costrain, and that allow any version that is higher or equal to 2.0 and lower than 3.0.
If this issue were reproducible, it would eventually be a bug, not something we expect to fix on these applications.

apaderno’s picture

Assigned: Unassigned » apaderno
Status: Needs review » Fixed

Thank you for your contribution! I am going to update the project.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

vuil’s picture

I added my employer only.

apaderno’s picture

Related issues: +#3089715: [D8] Partner Link

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.