Fix a bug by converting from a hyphen character (-) to underscore (_) to create a machine name ($cloud_context) for a cloud service provider name

CommentFileSizeAuthor
#4 3086957-4.patch5.68 KByas
#2 3086957-2.patch1.52 KByas
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yas created an issue. See original summary.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Needs work » Needs review
Related issues: +#3084313: Composer could not parse version constraint / could not load package
FileSize
3086957-2.patch1.52 KB

@baldwinlouie
@xiaohua-guan
@masami

Could you please review the patch?

Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented

@yas

The patch looks good to me.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
FileSize
3086957-4.patch5.68 KB

Thank you for your review. I'll merge the patch to 8.x-1.x and 8.x-2.x and close this issue as Fixed.

  • yas committed 112c713 on 8.x-1.x 
    Issue #3086957 by yas, Xiaohua Guan: Fix to create a machine name for a...

  • yas committed 177abfb on 8.x-2.x 
    Issue #3086957 by yas, Xiaohua Guan: Fix to create a machine name for a...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.