Problem/Motivation

The Mark as Read functionality is broken due change in behavior.

The functionality was removed here: https://github.com/goalgorilla/open_social/pull/1479/files#diff-989059a6...
but we forget that MARK_AS_READ status of activity decides the bg-colour of notifications in notification drop-down via notification bell icon in the header here: https://github.com/goalgorilla/open_social/blob/8.x-7.x/modules/custom/a...

Proposed resolution

  1. Remove the depcreation note
  2. Update notification.js to give a callback to /ajax/notifications-mark-as-read
  3. Update js code to fix the mark as read functionality

Comments

navneet0693 created an issue. See original summary.

navneet0693’s picture

navneet0693’s picture

Status: Active » Needs review

"Mark As Read" will be completely removed in https://github.com/goalgorilla/open_social/pull/1547

navneet0693’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

bramtenhove’s picture