Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
The Mark as Read functionality is broken due change in behavior.
The functionality was removed here: https://github.com/goalgorilla/open_social/pull/1479/files#diff-989059a6...
but we forget that MARK_AS_READ status of activity decides the bg-colour of notifications in notification drop-down via notification bell icon in the header here: https://github.com/goalgorilla/open_social/blob/8.x-7.x/modules/custom/a...
Proposed resolution
- Remove the depcreation note
- Update notification.js to give a callback to /ajax/notifications-mark-as-read
- Update js code to fix the mark as read functionality
Comments
Comment #2
navneet0693 CreditAttribution: navneet0693 as a volunteer and commentedImprove the code here: https://github.com/goalgorilla/open_social/pull/1547/files#diff-4a8db74d...
Comment #3
navneet0693 CreditAttribution: navneet0693 as a volunteer and commented"Mark As Read" will be completely removed in https://github.com/goalgorilla/open_social/pull/1547
Comment #6
navneet0693 CreditAttribution: navneet0693 as a volunteer and commentedComment #8
bramtenhove CreditAttribution: bramtenhove for Open Social commented