drupal-check -d web/modules/contrib/colorbox_load
 4/4 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ------------------------------------------------------------------
  Line   src/Renderer.php
 ------ ------------------------------------------------------------------
  20     Call to deprecated function drupal_render_root():
         as of Drupal 8.0.x, will be removed before Drupal 9.0.0. Use the
 ------ ------------------------------------------------------------------


 [ERROR] Found 1 error
CommentFileSizeAuthor
#2 colorbox_load-deprecated_code-3087552-2-8x_1x_dev.patch615 bytesdakruchko
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dakruchko created an issue. See original summary.

dakruchko’s picture

dakruchko CreditAttribution: dakruchko at EPAM Systems commented
FileSize
colorbox_load-deprecated_code-3087552-2-8x_1x_dev.patch615 bytes

please review

dakruchko’s picture

dakruchko CreditAttribution: dakruchko at EPAM Systems commented
Assigned: dakruchko » Unassigned
Status: Active » Needs review
NickDickinsonWilde’s picture

NickDickinsonWilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
CreditAttribution: NickDickinsonWilde commented
Status: Needs review » Needs work

Thanks for the report - and the patch. Committing with a change - we want to use dependency injection; \Drupal::[function] should be avoided in OOP code - ie fine in *.module but not so much in classes.

  • NickWilde committed 976d093 on 8.x-1.x 
    Issue #3087552 by dakruchko, NickWilde: Drupal 9 Deprecated Code Report
NickDickinsonWilde’s picture

NickDickinsonWilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
CreditAttribution: NickDickinsonWilde commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.