See pareview.sh report https://pareview.sh/pareview/https-git.drupal.org-project-editor_note.gi...
errors

CommentFileSizeAuthor
#4 Screen Shot 2019-10-14 at 1.51.55 PM.png137.33 KBdima.iluschenko
#2 editor_note.patch8.75 KBpurvitagupta
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Rostislav Sergeenkov created an issue. See original summary.

purvitagupta’s picture

purvitagupta CreditAttribution: purvitagupta commented
FileSize
editor_note.patch8.75 KB

Hello,
Here is the patch for coding standard.

purvitagupta’s picture

purvitagupta CreditAttribution: purvitagupta commented
Status: Active » Needs review
dima.iluschenko’s picture

dima.iluschenko
Location Malaga
CreditAttribution: dima.iluschenko at EPAM Systems commented
Assigned: Rostislav Sergeenkov » dima.iluschenko
Issue summary: View changes
Status: Needs review » Needs work
FileSize
Screen Shot 2019-10-14 at 1.51.55 PM.png137.33 KB

@purvitagupta sorry but we couldn't apply your patch. Please check your work after your changes:
errors

Rostislav Sergeenkov’s picture

Rostislav Sergeenkov CreditAttribution: Rostislav Sergeenkov at EPAM Systems commented
Category: Bug report » Task

  • dima.iluschenko committed 70b61e7 on 8.x-1.x 
    Issue #3087566 by dima.iluschenko: Fix code style issues and DI

dima.iluschenko’s picture

dima.iluschenko
Location Malaga
CreditAttribution: dima.iluschenko at EPAM Systems commented
Status: Needs work » Fixed

The issue was fixed.
https://pareview.sh/pareview/https-git.drupal.org-project-editor_note.gi...

Rostislav Sergeenkov’s picture

Rostislav Sergeenkov CreditAttribution: Rostislav Sergeenkov at EPAM Systems commented
Rostislav Sergeenkov’s picture

Rostislav Sergeenkov CreditAttribution: Rostislav Sergeenkov at EPAM Systems commented
Status: Fixed » Closed (fixed)