Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
drupal-check web/modules/contrib/video_embed_html5
5/5 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
------ ----------------------------------------------------------------
Line src/Plugin/video_embed_field/Provider/Html5.php
------ ----------------------------------------------------------------
101 Call to deprecated function file_prepare_directory():
in Drupal 8.7.0, will be removed before Drupal 9.0.0.
Use \Drupal\Core\File\FileSystemInterface::prepareDirectory().
------ ----------------------------------------------------------------
[ERROR] Found 1 error
Comment | File | Size | Author |
---|---|---|---|
#10 | interdiff-3087579-6-10.txt | 354 bytes | mrinalini9 |
#10 | 3087579-10.patch | 1.14 KB | mrinalini9 |
| |||
#6 | 3087579-6.patch | 745 bytes | Deeksha B |
| |||
#2 | video_embed_html5-deprecated_code-3087579-2-8x_1x_dev.patch | 793 bytes | dakruchko |
|
Comments
Comment #2
dakruchko CreditAttribution: dakruchko at EPAM Systems commentedplease review
Comment #3
dakruchko CreditAttribution: dakruchko at EPAM Systems commentedComment #4
margaritka.kurkul CreditAttribution: margaritka.kurkul at EPAM Systems commentedTested and reviewed. The module works as expected.
Comment #5
robin.ingelbrecht CreditAttribution: robin.ingelbrecht at EntityOne commentedService should be injected in to the plugin
Comment #6
Deeksha B CreditAttribution: Deeksha B at Specbee commentedI have apply the patch, Please review.
Comment #7
John Cook CreditAttribution: John Cook at Creode commentedThe patch from @Deeksha B in comment #6 looks good and applies cleanly.
The injected service is being used as requested by @robin.ingelbrecht
The results after the patch are:
Marking as RTBC.
Comment #8
John Cook CreditAttribution: John Cook at Creode commentedI've run the patch against upgrade status and there's and outstanding issue:
Because of this I've changing the status back to Needs work, and added the Novice tag for adding the
core_version_requirement
option in the info.yml file.Comment #9
mrinalini9 CreditAttribution: mrinalini9 at Srijan | A Material+ Company for Drupal India Association commentedComment #10
mrinalini9 CreditAttribution: mrinalini9 at Srijan | A Material+ Company for Drupal India Association commentedUpdated patch and added 'core_version_requirement' as mentioned in #8, please review.
Comment #11
rpayanmThanks. The last patch looks good for me.
I'm moving to RTBC.
Comment #12
AnybodyAlso consider: #3149248: Automated Drupal 9 compatibility fixes
Confirming RTBC and priority of this issue, currently the module is not usable with Drupal 9 through composer!
Comment #14
robin.ingelbrecht CreditAttribution: robin.ingelbrecht at EntityOne commentedThanks! This has been committed