drupal-check web/modules/contrib/video_embed_html5
 5/5 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ----------------------------------------------------------------
  Line   src/Plugin/video_embed_field/Provider/Html5.php
 ------ ----------------------------------------------------------------
  101    Call to deprecated function file_prepare_directory():
         in Drupal 8.7.0, will be removed before Drupal 9.0.0.
         Use \Drupal\Core\File\FileSystemInterface::prepareDirectory().
 ------ ----------------------------------------------------------------


 [ERROR] Found 1 error
CommentFileSizeAuthor
#10 interdiff-3087579-6-10.txt354 bytesmrinalini9
#10 3087579-10.patch1.14 KBmrinalini9
#6 3087579-6.patch745 bytesDeeksha B
#2 video_embed_html5-deprecated_code-3087579-2-8x_1x_dev.patch793 bytesdakruchko
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dakruchko created an issue. See original summary.

dakruchko’s picture

dakruchko CreditAttribution: dakruchko at EPAM Systems commented
FileSize
video_embed_html5-deprecated_code-3087579-2-8x_1x_dev.patch793 bytes

please review

dakruchko’s picture

dakruchko CreditAttribution: dakruchko at EPAM Systems commented
Assigned: dakruchko » Unassigned
Status: Active » Needs review
margaritka.kurkul’s picture

margaritka.kurkul CreditAttribution: margaritka.kurkul at EPAM Systems commented
Status: Needs review » Reviewed & tested by the community

Tested and reviewed. The module works as expected.

5/5 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
 [OK] No errors
robin.ingelbrecht’s picture

robin.ingelbrecht CreditAttribution: robin.ingelbrecht at EntityOne commented
Status: Reviewed & tested by the community » Needs work

Service should be injected in to the plugin

Deeksha B’s picture

Deeksha B CreditAttribution: Deeksha B at Specbee commented
Status: Needs work » Needs review
FileSize
3087579-6.patch745 bytes

I have apply the patch, Please review.

John Cook’s picture

John Cook CreditAttribution: John Cook at Creode commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +ContributionWeekend2020

The patch from @Deeksha B in comment #6 looks good and applies cleanly.

The injected service is being used as requested by @robin.ingelbrecht

The results after the patch are:

./vendor/bin/drupal-check modules/contrib/video_embed_html5/
 5/5 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

                                                                                             
 [OK] No errors

Marking as RTBC.

John Cook’s picture

John Cook CreditAttribution: John Cook at Creode commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Novice

I've run the patch against upgrade status and there's and outstanding issue:

$ drush us-a video_embed_html5
 [notice] Processing /var/www/drupalvm/drupal/web/modules/contrib/video_embed_html5.
 5/5 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%


================================================================================
Video Embed HTML5,  8.x-1.1
Scanned on Thu, 05/28/2020 - 11:19

FILE: web/modules/contrib/video_embed_html5/video_embed_html5.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    Add `core_version_requirement: ^8 || ^9` to      
                    video_embed_html5.info.yml to designate that the module is  
                    compatible with Drupal 9. See                               
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

Because of this I've changing the status back to Needs work, and added the Novice tag for adding the core_version_requirement option in the info.yml file.

mrinalini9’s picture

mrinalini9 CreditAttribution: mrinalini9 at Srijan | A Material+ Company for Drupal India Association commented
Assigned: Unassigned » mrinalini9
mrinalini9’s picture

mrinalini9 CreditAttribution: mrinalini9 at Srijan | A Material+ Company for Drupal India Association commented
Assigned: mrinalini9 » Unassigned
Status: Needs work » Needs review
FileSize
3087579-10.patch1.14 KB
interdiff-3087579-6-10.txt354 bytes

Updated patch and added 'core_version_requirement' as mentioned in #8, please review.

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
CreditAttribution: rpayanm as a volunteer and at Kadabra commented
Status: Needs review » Reviewed & tested by the community

Thanks. The last patch looks good for me.

I'm moving to RTBC.

Anybody’s picture

Anybody
Primary language German
Location Porta Westfalica
CreditAttribution: Anybody at DROWL.de commented

Also consider: #3149248: Automated Drupal 9 compatibility fixes

Confirming RTBC and priority of this issue, currently the module is not usable with Drupal 9 through composer!

  • mrinalini9 authored 9b5cfbf on 8.x-1.x 
    Issue #3087579 by mrinalini9: Drupal 9 Deprecated Code Report
robin.ingelbrecht’s picture

robin.ingelbrecht CreditAttribution: robin.ingelbrecht at EntityOne commented
Status: Reviewed & tested by the community » Fixed

Thanks! This has been committed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.