CommentFileSizeAuthor
#4 3087646-4.patch9.64 KBMasami
#3 3087646-3.patch9.64 KBMasami
#2 3087646.patch19.67 KBMasami
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Masami created an issue. See original summary.

Masami’s picture

Masami CreditAttribution: Masami commented
FileSize
3087646.patch19.67 KB
Masami’s picture

Masami CreditAttribution: Masami commented
FileSize
3087646-3.patch9.64 KB
Masami’s picture

Masami CreditAttribution: Masami commented
Status: Active » Needs review
FileSize
3087646-4.patch9.64 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented

@masami

Thank you for adding the test cases. It looks good to me.

@xiaohua-guan
@baldwinlouie

Could you please review the patch?

Xiaohua Guan’s picture

Xiaohua Guan CreditAttribution: Xiaohua Guan commented

@yas

The patch file looks good to me.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented

@xiaohua-guan

Thank you for your review. I'll merge the patch to 8.x-1.x and 8.x-2.x and close this issue as Fixed.

  • yas committed 803d50c on 8.x-1.x authored by Masami 
    Issue #3087646 by Masami, yas, Xiaohua Guan: Add test cases for Security...

  • yas committed 167af02 on 8.x-2.x authored by Masami 
    Issue #3087646 by Masami, yas, Xiaohua Guan: Add test cases for Security...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.