Remove deprecations, compatibility with Drupal 9

This update the type hints but it still uses the old, deprecated services.

Expanding the scope of this to all deprecations, it's hard to keep that in separate issues as they tend to conflict and it's hard to test that everything is covered.

Working on it a bit.

Ok, this should fix everything except the config sync directory, which is a 8.8 deprecation and only used in tests.

This uses the new create pattern in a few places which allows us to avoid duplicating the parent constructor arguments and just assign what we need additionally. If we'd ever want to add unit tests for this then a setter method could be added for the additional properties, but that does seem very unlikely for these classes.

Ah, didn't think this through, so using the $this->entityTypeManager property in viewsData does require 8.8 obviously, so updating the version constraint and fixing everything.

It's up to @kristiaanvandeneynde to decide when to drop 8.7 support, I'll start doing that for my projects in march, FYI :)

One more thing, didn't see that composer.json has a drupal/core requirement already, that's not really necessary anymore as it respects core_version_requirement automatically, but updating that too for now.

Looks good to me, and all tests are passing.

+++ b/tests/modules/group_test/group_test.info.yml
@@ -2,8 +2,7 @@ name: 'Group test'
-version: VERSION
-core: '8.x'
+core_version_requirement: ^8.8 || ^9

+++ b/tests/modules/group_test_config/group_test_config.info.yml
@@ -2,7 +2,6 @@ name: 'Group configuration tests'
-version: VERSION
-core: '8.x'
+core_version_requirement: ^8.8 || ^9

+++ b/tests/modules/group_test_plugin/group_test_plugin.info.yml
@@ -2,8 +2,7 @@ name: 'Group test plugin'
-version: VERSION
-core: '8.x'
+core_version_requirement: ^8.8 || ^9

+++ b/tests/modules/group_test_views/group_test_views.info.yml
@@ -2,8 +2,7 @@ name: 'Group test views'
-version: VERSION
-core: '8.x'
+core_version_requirement: ^8.8 || ^9

This could be also removed as far as I read for test modules: #3096609: Allow contrib test modules to not need a core or core_version_requirement key, but let's try to get this done ASAP as it's blocking any module testing if depending on group.

Yeah, starting with 8.8.3 or so. I prefer to keep it, because having such a module present results in a hard fail for _any_ test. If another project has a require-dev dependency on group and still wants to support 8.7 then we'd break their tests. We could decide to remove it when the min version is increased the next time.

Thanks for the explanation, @berdir!

The changes here make sense. But without an actual commit, its hard to see if this will pass the testbot or not. So a tentative +1 on RTBC from me. With the caveat that there might need to be more testing/fixes after the initial patch lands.

I cannot get either patch #9 or #10 to install via composer. I'm running D8.8.5 & 1.0.0-rc5.

Okay, looks good to me and I agree it's time to bump the supported core version to 8.8

Big thanks to all those involved!

There's a couple instances of:

Providing context definitions via the "context" key is deprecated in Drupal 8.7.x and will be removed before Drupal 9.0.0. Use the "context_definitions" key instead. in the code still. Open a follow-up?

We still have the parent issue open: #3042771: Drupal 9 Deprecated Code Report. Now that this has been committed, we can run tests against 9.x as well there.

@heddn that has been fixed in #3087371: Replace ContextDefinition with EntityContextDefinition

@Berdir okay, will follow that issue.