Problem/Motivation

\Drupal\migrate\Plugin\Migration::get() has been deprecated since Drupal 8.1. It is an artifact of the heady days when migrations were config entities, and was kept as a BC layer when they were converted to plain plugins.

Proposed resolution

Remove this method in Drupal 9.

Remaining tasks

Do it.

User interface changes

None.

API changes

Deprecated method removal.

Data model changes

None.

Release notes snippet

None?

CommentFileSizeAuthor
#7 diff-5-7.txt3.41 KBquietone
#7 3088595-7.patch3.65 KBquietone
#5 Remove-Migration-3088595-5.patch2.6 KBarunkumark
#2 3088595-2.patch1.08 KBphenaproxima
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

phenaproxima created an issue. See original summary.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Active » Needs review
FileSize
3088595-2.patch1.08 KB
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
Status: Needs review » Reviewed & tested by the community

There were some uses of it at one point in migrate_tools, migrate_upgrade and migrate_plus until a little while ago. But that is now gone. So this should be fine to go. Yeah!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3088595-2.patch, failed testing. View results

arunkumark’s picture

arunkumark
Location Coimbatore
CreditAttribution: arunkumark as a volunteer and at DrupalPartners for Innoppl Technologies Pvt. Ltd commented
Status: Needs work » Needs review
FileSize
Remove-Migration-3088595-5.patch2.6 KB

Updated the patch with the resolution for the test cases.

Status: Needs review » Needs work

The last submitted patch, 5: Remove-Migration-3088595-5.patch, failed testing. View results

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Needs work » Needs review
FileSize
3088595-7.patch3.65 KB
diff-5-7.txt3.41 KB

Needed a reroll. Plus removed the legacy test.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs review » Reviewed & tested by the community

Looks good to me!

  • catch committed 6ffa1bd on 9.0.x 
    Issue #3088595 by quietone, phenaproxima, arunkumark, heddn: Remove...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed 6ffa1bd and pushed to 9.0.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.