Issues in code

Drupal coding standards issues in code:

(1.) The phpinsights.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu...

(2.)

FILE: ...rupal/pareviewsh/pareview_temp/src/Plugin/Block/PhpInsightsBlock.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 223 | WARNING | Unused variable $key.
--------------------------------------------------------------------------

(3.)

FILE: ...rupal/pareviewsh/pareview_temp/src/Plugin/Block/PhpInsightsBlock.php
--------------------------------------------------------------------------
FOUND 4 ERRORS AND 4 WARNINGS AFFECTING 7 LINES
--------------------------------------------------------------------------
  48 | ERROR   | [ ] Doc comment short description must start with a
     |         |     capital letter
  48 | ERROR   | [x] Doc comment short description must end with a full
     |         |     stop
  91 | WARNING | [x] A comma should follow the last multiline array item.
     |         |     Found: 0
  95 | WARNING | [x] A comma should follow the last multiline array item.
     |         |     Found: 'phpinsights/phpinsights'
 105 | WARNING | [x] A comma should follow the last multiline array item.
     |         |     Found: 0
 109 | WARNING | [x] A comma should follow the last multiline array item.
     |         |     Found: 'phpinsights/phpinsights'
 159 | ERROR   | [x] Expected newline after closing brace
 227 | ERROR   | [x] Expected newline after closing brace
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...drupal/pareviewsh/pareview_temp/src/Form/PhpInsightsSettingsForm.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 114 | ERROR | [x] Expected newline after closing brace
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Comment	File	Size	Author
#11	3088795-11.patch	921 bytes	vuil
#11	8.x-1.x: PHP 7.1 & MySQL 5.7, D8.7.8 1 pass
#8	3088795-8.patch	1.38 KB	vuil
#8	8.x-1.x: PHP 7.1 & MySQL 5.7, D8.7.8 1 pass
#5	3088795-5.patch	3.8 KB	vuil
#5	8.x-1.x: PHP 7.1 & MySQL 5.7, D8.7.8 1 pass
#2	3088795-2.patch	906 bytes	vuil
#2	8.x-1.x: PHP 7.1 & MySQL 5.7, D8.7.8 1 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

18 October 2019 at 12:05

vuil created an issue. See original summary.

Log in or register to post comments

Comment #2

vuil

Bulgaria 🇧🇬 🇪🇺 🌍

CreditAttribution: vuil at FFW commented 18 October 2019 at 12:17

Status:

Active

» Needs review

File	Size
3088795-2.patch	906 bytes
8.x-1.x: PHP 7.1 & MySQL 5.7, D8.7.8 1 pass

The patch for (1.) only.

Log in or register to post comments

Comment #3

18 October 2019 at 12:34

vuil committed 993b7fd on 8.x-1.x

Issue #3088795 by vuil: Implement hook_help() function.

Log in or register to post comments

Comment #4

vuil

Bulgaria 🇧🇬 🇪🇺 🌍

CreditAttribution: vuil at FFW commented 18 October 2019 at 12:34

Status:

Needs review

» Needs work

Needs work for (2.) and (3.) points...

Log in or register to post comments

Comment #5

vuil

Bulgaria 🇧🇬 🇪🇺 🌍

CreditAttribution: vuil at FFW commented 18 October 2019 at 12:39

Status:

Needs work

» Needs review

File	Size
3088795-5.patch	3.8 KB
8.x-1.x: PHP 7.1 & MySQL 5.7, D8.7.8 1 pass

A patch for 2. & 3.

Log in or register to post comments

Comment #6

18 October 2019 at 12:43

vuil committed d57b520 on 8.x-1.x

Issue #3088795 by vuil: Apply coding standards.

Log in or register to post comments

Comment #7

vuil

Bulgaria 🇧🇬 🇪🇺 🌍

CreditAttribution: vuil at FFW commented 18 October 2019 at 12:47

Status:

Needs review

» Needs work

The latest issues:

FILE: ...rupal/pareviewsh/pareview_temp/src/Plugin/Block/PhpInsightsBlock.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
--------------------------------------------------------------------------
 48 | ERROR | [ ] Doc comment short description must start with a capital
    |       |     letter
 48 | ERROR | [x] Doc comment short description must end with a full stop
--------------------------------------------------------------------------

FILE: ...rupal/pareviewsh/pareview_temp/src/Plugin/Block/PhpInsightsBlock.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 224 | WARNING | Unused variable $key.
--------------------------------------------------------------------------

Log in or register to post comments

Comment #8

vuil

Bulgaria 🇧🇬 🇪🇺 🌍

CreditAttribution: vuil at FFW commented 18 October 2019 at 12:53

Status:

Needs work

» Needs review

File	Size
3088795-8.patch	1.38 KB
8.x-1.x: PHP 7.1 & MySQL 5.7, D8.7.8 1 pass

A patch for the issue #7 fix.

Log in or register to post comments

Comment #9

18 October 2019 at 13:11

vuil committed 9c1188c on 8.x-1.x

Issue #3088795 by vuil: annotation fixes and remove unused  variable.

Log in or register to post comments

Comment #10

vuil

Bulgaria 🇧🇬 🇪🇺 🌍

CreditAttribution: vuil at FFW commented 18 October 2019 at 13:13

Status:

Needs review

» Needs work

FILE: ...rupal/pareviewsh/pareview_temp/src/Plugin/Block/PhpInsightsBlock.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
 52 | ERROR | Missing parameter type
 54 | ERROR | Missing parameter type
--------------------------------------------------------------------------

Log in or register to post comments

Comment #11

vuil

Bulgaria 🇧🇬 🇪🇺 🌍

CreditAttribution: vuil at FFW commented 18 October 2019 at 13:15

Status:

Needs work

» Needs review

File	Size
3088795-11.patch	921 bytes
8.x-1.x: PHP 7.1 & MySQL 5.7, D8.7.8 1 pass

A patch to fix #10.

Log in or register to post comments

Comment #12

18 October 2019 at 13:22

vuil committed 2a656ab on 8.x-1.x
```
Issue #3088795 by vuil: Issues in code
```

Log in or register to post comments

Comment #13

vuil

Bulgaria 🇧🇬 🇪🇺 🌍

CreditAttribution: vuil at FFW commented 18 October 2019 at 13:23

Status:

Needs review

» Fixed

Log in or register to post comments

Comment #14

1 November 2019 at 13:24

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Log in or register to post comments