Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Drupal coding standards issues in code:
(1.) The phpinsights.module does not implement hook_help()
. See https://www.drupal.org/docs/develop/documenting-your-project/module-docu...
(2.)
FILE: ...rupal/pareviewsh/pareview_temp/src/Plugin/Block/PhpInsightsBlock.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
223 | WARNING | Unused variable $key.
--------------------------------------------------------------------------
(3.)
FILE: ...rupal/pareviewsh/pareview_temp/src/Plugin/Block/PhpInsightsBlock.php
--------------------------------------------------------------------------
FOUND 4 ERRORS AND 4 WARNINGS AFFECTING 7 LINES
--------------------------------------------------------------------------
48 | ERROR | [ ] Doc comment short description must start with a
| | capital letter
48 | ERROR | [x] Doc comment short description must end with a full
| | stop
91 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 0
95 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 'phpinsights/phpinsights'
105 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 0
109 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 'phpinsights/phpinsights'
159 | ERROR | [x] Expected newline after closing brace
227 | ERROR | [x] Expected newline after closing brace
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: ...drupal/pareviewsh/pareview_temp/src/Form/PhpInsightsSettingsForm.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
114 | ERROR | [x] Expected newline after closing brace
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
Comment | File | Size | Author |
---|---|---|---|
#11 | 3088795-11.patch | 921 bytes | vuil |
| |||
#8 | 3088795-8.patch | 1.38 KB | vuil |
| |||
#5 | 3088795-5.patch | 3.8 KB | vuil |
| |||
#2 | 3088795-2.patch | 906 bytes | vuil |
|
Comments
Comment #2
vuilThe patch for (1.) only.
Comment #4
vuilNeeds work for (2.) and (3.) points...
Comment #5
vuilA patch for 2. & 3.
Comment #7
vuilThe latest issues:
Comment #8
vuilA patch for the issue #7 fix.
Comment #10
vuilComment #11
vuilA patch to fix #10.
Comment #13
vuil