[D8] Web accessibility

Thank you for applying! I added the Git instructions for non-maintainer users. Reviewers will check the project and post comments to list what should be changed.

Really nice and useful Drupal 8 module. Congratulation!
Thanks for the contribution!

I will mention some of the issue which need to be fixed:

(1.)
Please replace the deprecated usage of drupal_set_message() with \Drupal::messenger() and Dependency Injection (DI) in Classes when need.

(2.)
Please correct the wrong usage of foreach ($service as $service) {...} in web_accessibility.module.

(3.)
Please fill free to replace dirname(__FILE__) with a simpler __DIR__ in .module web_accessibility_help() (hook_help) function. (Note: I will do the same suggestion to the official Drupal 8 documentation about.)

(4.)
It is always better to use single quotes for 'SELECT * FROM {web_accessibility_services} WHERE id = :id'
instead of "SELECT * FROM {web_accessibility_services} WHERE id = :id".

Hi.
Nitpick:

 $alias = \Drupal::service('path.alias_manager')->getAliasByPath('/node/' . $node->id());
  $nodeUrl = Url::fromUserInput($alias, ['absolute' => TRUE])->toString();

Use

$nodeUrl = $node->toUrl('canonical', ['absolute' => TRUE])->toString();

Move `URL_TOKEN` constant to service interface and use in `hook_form_alter`

...
foreach ($services as $service) {
      $serviceUrl = str_replace(WebServiceInterface::URL_TOKEN, $nodeUrl, $service->url);
...

Use Utility for check valid url

 elseif (!UrlHelper::isValid($url, TRUE)) {

in https://git.drupalcode.org/project/web_accessibility/blob/8.x-1.x/src/Fo...

I checked the following:

Manual Review

No duplication

[No: Causes] - Did not find any duplication

README.txt/README.md

[Yes: Follows]

Code long/complex enough for review

[Yes: Follows] - definitely nice to have the links right in the node form

3rd party assets/code

Everything I saw: [Yes: Follows]

Thank you for the contribution!

I checked all the problems mentioned above and saw that they had already been resolved.
I didn't find another security issue through manual review.

I set the issue status to Reviewed & tested by the community.

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

You need to edit the project from https://www.drupal.org/node/2946542/edit, to opt into security coverage.