• Add a fieldset incl. Pod list

screenshot-20191019a.png

CommentFileSizeAuthor
#5 screenshot-20191019a.png919.09 KByas
#4 3088945-4-interdiff.txt2.66 KByas
#4 3088945-4.patch24.64 KByas
#2 3088945.patch23.46 KBMasami
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Masami created an issue. See original summary.

Masami’s picture

Masami CreditAttribution: Masami commented
FileSize
3088945.patch23.46 KB
Masami’s picture

Masami CreditAttribution: Masami commented
Status: Active » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
FileSize
3088945-4.patch24.64 KB
3088945-4-interdiff.txt2.66 KB

@masami

Thank you for adding the fieldset. It looks good to me and fixed the coding standard violations. Please review the patch.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Issue summary: View changes
FileSize
screenshot-20191019a.png919.09 KB
Masami’s picture

Masami CreditAttribution: Masami commented
Status: Needs review » Reviewed & tested by the community

@yas
Thank you for fixing the coding standard violation.
It looks good!

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented

@masami

Thank you for your review. I'll merge the patch to 8.x-2.x and close this issue as Fixed.

  • yas committed 4446dd2 on 8.x-2.x authored by Masami 
    Issue #3088945 by yas, Masami: Add Pod list onto Node detail view
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Status: Reviewed & tested by the community » Fixed
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
CreditAttribution: yas at DOCOMO Innovations, Inc. commented
Related issues: +#3084313: Composer could not parse version constraint / could not load package

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.