Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Review of the 8.x-1.x branch (commit 5fa121d):
- Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
- The INTRODUCTION section is missing.
- The REQUIREMENTS section is missing.
- The INSTALLATION section is missing.
- The CONFIGURATION section is missing.
- Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/src/DomainVideoList.php -------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------- 44 | ERROR | [x] Expected 1 blank line before function; 0 found -------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------- Time: 1.03 secs; Memory: 4Mb
- DrupalPractice has found some issues with your code, but could be false positives.
FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/src/DomainVideoList.php -------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------- 83 | WARNING | \Drupal calls should be avoided in classes, use | | dependency injection instead -------------------------------------------------------------------------- Time: 594ms; Memory: 4Mb
- No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.
Comment | File | Size | Author |
---|---|---|---|
#5 | coding-standard-3089230-5.patch | 3.93 KB | Serhii Muzychuk |
Comments
Comment #2
MahtabAlam@i-trokhanenko Good catch. I have created patch to fix the same.
Comment #3
MahtabAlam@i-trokhanenko Good catch. I have created patch to fix the same.
Comment #4
i-trokhanenkoPlease fix issue on /src/DomainVideoList.php
Comment #5
Serhii Muzychuk CreditAttribution: Serhii Muzychuk at RockSolid PSF commentedChanged coding standard.
Please check.
Comment #6
a.dreichan+1 RTBC
Comment #8
i-trokhanenkoThanks!