Review of the 8.x-1.x branch (commit 5fa121d):

  • Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
    
    FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/src/DomainVideoList.php
    --------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    --------------------------------------------------------------------------
     44 | ERROR | [x] Expected 1 blank line before function; 0 found
    --------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    --------------------------------------------------------------------------
    
    Time: 1.03 secs; Memory: 4Mb
    
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/src/DomainVideoList.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     83 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
    --------------------------------------------------------------------------
    
    Time: 594ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

i-trokhanenko created an issue. See original summary.

MahtabAlam’s picture

@i-trokhanenko Good catch. I have created patch to fix the same.

MahtabAlam’s picture

Status: Active » Needs review
FileSize
1.76 KB

@i-trokhanenko Good catch. I have created patch to fix the same.

i-trokhanenko’s picture

Status: Needs review » Needs work

Please fix issue on /src/DomainVideoList.php

83 | WARNING | \Drupal calls should be avoided in classes, use
    |         | dependency injection instead
Serhii Muzychuk’s picture

Status: Needs work » Needs review
Issue tags: +RockSolidCodeSprint
FileSize
3.93 KB

Changed coding standard.
Please check.

a.dreichan’s picture

Status: Needs review » Reviewed & tested by the community

+1 RTBC

i-trokhanenko’s picture

Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.