Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.In css/src/components/skip-link.css:
The transform property is prefixed in the sourcecode:
-webkit-transform: translateX(-50%);
-ms-transform: translateX(-50%);
transform: translateX(-50%);
This is redundant since autoprefixer already takes care of this in the dist folder.
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | 3089269-11.patch | 500 bytes | ravi.shankar |
| #9 | 3089269-9.patch | 467 bytes | heykarthikwithu |
| #3 | claro-remove-prefixed-values-3089269-3.patch | 1.04 KB | iro |
| #2 | remove-prefixed-values-3089269-13319053.patch | 418 bytes | martijn.cuppens |
Comments
Comment #2
martijn.cuppens CreditAttribution: martijn.cuppens at iO commentedComment #3
iro CreditAttribution: iro at Point Blank commentedcss/src/components/skip-link.css is the generated file and should not be edited directly.
css/src/components/skip-link.pcss.css is the source file where the changes should be done and then it should be compiled.
I am adding the patch.
Comment #4
cedric_aI think this issue is no more relevant as the
skip-link.pcss.cssfile is now correct in the Core (8.8.x) version of Claro.Comment #5
lauriiiThis should be rerolled on top of Drupal core.
Comment #6
huzookaIsn't it better to implement the new skip-link styles instead of just removing the legacy properties?
Comment #7
iro CreditAttribution: iro at Point Blank commentedThe patch at #3 was against the Core (8.8.x) version of Claro. The component is not correct as mentioned at #4.
I change the status and remove the Needs reroll tag since it is on top of Drupal core.
Comment #8
huzookaComment #9
heykarthikwithure-rolled the patch
Comment #10
huzookaRe #9:
@heykarthikwithu, you forgot to remove the
-ms-transform: translateX(-50%);line :)Comment #11
ravi.shankar CreditAttribution: ravi.shankar at OpenSense Labs commentedHere I have made changes as suggested in #10
Comment #12
huzookaThis is RTBC when #11 passes (it will 😊).
Comment #13
huzookaAs I predicted...
Comment #14
alexpottCommitted and pushed df68b01146 to 9.0.x and c0a6ca5b56 to 8.9.x and 6740a58e2f to 8.8.x. Thanks!
Backported to 8.8.x as this doesn't actually affect run-time code - the results of processing the pcss file are the same and Claro is also experimental.