Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Rangaswini created an issue. See original summary.

Rangaswini’s picture

Issue summary: View changes

The library's name should be unique.
Two different names :
1. Clone gives name - "eval-math"
2. After download, it shows -"eval-math-master"

Rangaswini’s picture

Status: Active » Needs review
FileSize
1.3 KB
JayKandari’s picture

Status: Needs review » Needs work

Hi @Rangaswini,
Thanks for your contribution. Please find some minor changes required for the patch given below.

  1. +++ b/README.txt
    @@ -0,0 +1,35 @@
    +NAME
    

    Can we provide a space above this heading.

  2. +++ b/README.txt
    @@ -0,0 +1,35 @@
    +
     
    

    Can we remove 1 extra line from end.

Also, apart from this, Two points:

1. The patch was not getting applied correctly.

➜  formula_field git:(7.x-2.x) ✗ git apply readme_file_update-3089356.patch
readme_file_update-3089356.patch:41: new blank line at EOF.
+
warning: 1 line adds whitespace errors.

2. Seems the patch file name was slightly off the naming convention. Comment number could be a part of the patch name. (https://www.drupal.org/node/707484)

Rest Looks good. :)
Thank You.

Rangaswini’s picture

Rangaswini’s picture

Assigned: Rangaswini » Unassigned
Status: Needs work » Needs review

JayKandari’s picture

Status: Needs review » Fixed

LGTM. Committed & pushed to 7.x-2.x
Thanks, @rangaswini for your contribution.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.