Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Comment | File | Size | Author |
---|---|---|---|
#5 | readme_file_update-3089356-5.patch | 1.3 KB | Rangaswini |
#3 | readme_file_update-3089356.patch | 1.3 KB | Rangaswini |
Comments
Comment #2
Rangaswini CreditAttribution: Rangaswini at QED42 commentedThe library's name should be unique.
Two different names :
1. Clone gives name - "eval-math"
2. After download, it shows -"eval-math-master"
Comment #3
Rangaswini CreditAttribution: Rangaswini at QED42 commentedComment #4
JayKandariHi @Rangaswini,
Thanks for your contribution. Please find some minor changes required for the patch given below.
Can we provide a space above this heading.
Can we remove 1 extra line from end.
Also, apart from this, Two points:
1. The patch was not getting applied correctly.
2. Seems the patch file name was slightly off the naming convention. Comment number could be a part of the patch name. (https://www.drupal.org/node/707484)
Rest Looks good. :)
Thank You.
Comment #5
Rangaswini CreditAttribution: Rangaswini at QED42 commentedComment #6
Rangaswini CreditAttribution: Rangaswini at QED42 commentedComment #8
JayKandariLGTM. Committed & pushed to 7.x-2.x
Thanks, @rangaswini for your contribution.