Problem/Motivation

As part of #3067216: [meta] Deprecate (in 8.8) and remove (in 9.0) polyfills that are no longer needed the domready asset library was marked deprecated in 8.8.
see: #3086375: Deprecate domready and remove usages in core
All files and usage of domready should be removed in Drupal 9.

Proposed resolution

Remove domready from 9.0.x
Existing change record: domready is deprecated

Remaining tasks

  1. Post patch removing domready

User interface changes

None

API changes

Data model changes

Release notes snippet

Included in the release notes for #3089469: Remove html5shiv in Drupal 9 - intentionally not copied here to avoid duplication-confusion.

CommentFileSizeAuthor
#3 interdiff_2-3.txt265 byteszrpnr
#3 3089480-3.patch1.77 KBzrpnr
#2 3089480-2.patch1.45 KBzrpnr
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

zrpnr created an issue. See original summary.

zrpnr’s picture

zrpnr
he/him
Primary language English
Location UTC-7
CreditAttribution: zrpnr at Acquia commented
Issue summary: View changes
Status: Active » Needs review
FileSize
3089480-2.patch1.45 KB

Use of domready was almost all removed in #3086375: Deprecate domready and remove usages in core
This removes the asset library and the files.

Updated the IS to point to the existing change record.

zrpnr’s picture

zrpnr
he/him
Primary language English
Location UTC-7
CreditAttribution: zrpnr at Acquia commented
FileSize
3089480-3.patch1.77 KB
interdiff_2-3.txt265 bytes

The domready global is no longer needed in .eslintrc, removed.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
CreditAttribution: bnjmnm at Acquia commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Updated the release notes snippet to refer to the snippet on #3089469: Remove html5shiv in Drupal 9 and did some grepping around and everything looks good. RTBC.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented

Fixing credits.

  • Gábor Hojtsy committed 400575a on 9.0.x 
    Issue #3089480 by zrpnr, bnjmnm: Remove domready in Drupal 9
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Reviewed & tested by the community » Fixed

Sitting in person with @nod, who reviewed and nodded that this looked right.

Gábor Hojtsy credited nod_.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.