Hello all, it’s time for the weekly migration initiative meeting. The meeting will take place in slack in various threads
This meeting:
➤ Is for core migrate maintainers and developers and anybody else in the community with an interest in migrations
➤ Usually happens every Thursday and alternates between 1400 and 2100 UTC.
➤ Is done over chat.
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to here.
➤*Transcript will be exported and posted* to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.
alison: @mikelutz @heddn @quietone @phenaproxima (he/him) @Gábor Hojtsy (he/him) @webchick @Nick Dickinson Wilde @damienmckenna @benjifisher @Seth Green @Joshua Turton (srjosh) Meeting time!(First time moderating, bear with me...)
0️⃣ Who is here today? Give your name and ... a place you'd love to visit (or live), where you've never been. (edited)
| webchick |
Angie / webchick, and I’ve always wanted to visit Japan since I was a little kid. :slightly_smiling_face: |
| damienmckenna |
Damien (he/him), and I also think Japan would be neat to visit but Fukashima scared me off; probably Montréal. |
| quietone |
for me it is the rift valley in Africa |
| benjifisher |
Benji FisherI have never been to Hawaii, but that is where I am going next month. |
| alison |
Alison/alisonjo315 -- New Zealand, ever since 5th grade (yes that was before the LOTR movies)Awesome, Benji! |
| Joshua Turton (srjosh) |
@Joshua Turton (srjosh) and I’d love to go lots of places. |
1️⃣ Is there anybody here that I didn’t @ mention above who would like to be on the list to be flagged for migration meetings? (or anybody on that list that wants to be removed?)
2️⃣ What do we want to talk about? We’ll hit the NR issues by default. What else needs a thread?
| webchick |
Maybe hitting on multilingual migration specifically? What we can do to unblock? |
| alison |
Excellent! It was part of last week's agenda, so I already had it queued up for this week :slightly_smiling_face: |
| alison |
@quietone do you know the issue tag offhand? is it "i18n-migrate" or something else? |
| benjifisher |
#3024682: Migrate UI - add human-friendly module names to the Review form (progress report) |
3️⃣ Migration multilingual issues here. Node master migration, plus stabilizing of multilingual module.
| alison |
"Meta" issue re: stabilizing migrate-multilingual module: #2208401: [META] Remaining multilingual migration paths (edited) |
| webchick |
So I sent out a tweet about this, and so has Gábor https://twitter.com/webchick/status/1186769241086676992 … I feel like that hasn’t been successful in raising testers for these issues. I’m wondering if we maybe need a post to g.d.o/core or something that goes out to Drupal Planet / @drupal that has specific instructions on who we’re looking for, what needs to happen, etc. |
| webchick |
Like “If you have a Drupal 7 multilingual site, you need to apply this patch here and go to this specific place, and report back at X with your findings” or… something that’s actually real. :slightly_smiling_face: |
| quietone |
We need to get these "Must have - improvments/bugs fixes that need to be committed first" to RTBC while we call for testing of the node revision issue. |
| alison |
@quietone I don't know how to find the NR queue that's specifically for multilingual migration things, so sorry -- could you point me? |
| quietone |
There are 2 of those issues are straightforward |
| quietone |
The MET A issue is the most accruate now |
| alison |
Here's a NR one in the overall NR list: #3076447: Migrate D7 entity translation revision translations |
| alison |
Ahhh ok, thanks @quietone |
| webchick |
Right, so what is needed to get those to RTBC? Technical reviews I guess? Any particular profile of person we’re looking for? |
| Gábor Hojtsy (he/him) |
@quietone @webchick As far as I understand people with data sets with node revisions they intend to keep (eg. accountability, rollback ability, etc) and content translation and/or entity translation |
| webchick |
I wonder if we could ask around at Acquia for a customer site that has those things |
| quietone |
for the three currently listed a having to go in first, their is only one that the migrate maintainer need to discuss, that is #3086238: getHighestId() should not fail when there is a destination id with type string |
| quietone |
The others are easier, one is just moving test code to a new file. |
| Gábor Hojtsy (he/him) |
@webchick re Acquia customer site, I asked Shannon to shop it around at Acquia PS, not sure if she had success… I am not sure she shopped it around at the right part of PS(?) |
| webchick |
I reached out on our Drupal channel |
| webchick |
We’ll see what happens |
4️⃣ Add checkrequirements to VariableTranslation source plugin
5️⃣ Migrate UI - use human-friendly module names on the Review form (edited)
6️⃣ Source count caching does not work for SQL sources
7️⃣ Default Value Migration Process plugin produces unexpected behavior when updating list field from D7 to D8
8️⃣ And my personal favorite: SQL source plugins: allow defining conditions in migration yml
@mikelutz @heddn @quietone @phenaproxima (he/him) @Gábor Hojtsy (he/him) @webchick @Nick Dickinson Wilde @damienmckenna @benjifisher @Seth Green @Joshua Turton (srjosh) Meeting time!(First time moderating, bear with me...)
0️⃣ Who is here today? Give your name and ... a place you'd love to visit (or live), where you've never been. (edited)
| webchick |
Angie / webchick, and I’ve always wanted to visit Japan since I was a little kid. :slightly_smiling_face: |
| damienmckenna |
Damien (he/him), and I also think Japan would be neat to visit but Fukashima scared me off; probably Montréal. |
| quietone |
for me it is the rift valley in Africa |
| benjifisher |
Benji FisherI have never been to Hawaii, but that is where I am going next month. |
| alison |
Alison/alisonjo315 -- New Zealand, ever since 5th grade (yes that was before the LOTR movies)Awesome, Benji! |
| Joshua Turton (srjosh) |
@Joshua Turton (srjosh) and I’d love to go lots of places. |
1️⃣ Is there anybody here that I didn’t @ mention above who would like to be on the list to be flagged for migration meetings? (or anybody on that list that wants to be removed?)
2️⃣ What do we want to talk about? We’ll hit the NR issues by default. What else needs a thread?
| webchick |
Maybe hitting on multilingual migration specifically? What we can do to unblock? |
| alison |
Excellent! It was part of last week's agenda, so I already had it queued up for this week :slightly_smiling_face: |
| alison |
@quietone do you know the issue tag offhand? is it "i18n-migrate" or something else? |
| benjifisher |
#3024682: Migrate UI - add human-friendly module names to the Review form (progress report) |
3️⃣ Migration multilingual issues here. Node master migration, plus stabilizing of multilingual module.
| alison |
"Meta" issue re: stabilizing migrate-multilingual module: #2208401: [META] Remaining multilingual migration paths (edited) |
| webchick |
So I sent out a tweet about this, and so has Gábor https://twitter.com/webchick/status/1186769241086676992 … I feel like that hasn’t been successful in raising testers for these issues. I’m wondering if we maybe need a post to g.d.o/core or something that goes out to Drupal Planet / @drupal that has specific instructions on who we’re looking for, what needs to happen, etc. |
| webchick |
Like “If you have a Drupal 7 multilingual site, you need to apply this patch here and go to this specific place, and report back at X with your findings” or… something that’s actually real. :slightly_smiling_face: |
| quietone |
We need to get these "Must have - improvments/bugs fixes that need to be committed first" to RTBC while we call for testing of the node revision issue. |
| alison |
@quietone I don't know how to find the NR queue that's specifically for multilingual migration things, so sorry -- could you point me? |
| quietone |
There are 2 of those issues are straightforward |
| quietone |
The MET A issue is the most accruate now |
| alison |
Here's a NR one in the overall NR list: #3076447: Migrate D7 entity translation revision translations |
| alison |
Ahhh ok, thanks @quietone |
| webchick |
Right, so what is needed to get those to RTBC? Technical reviews I guess? Any particular profile of person we’re looking for? |
| Gábor Hojtsy (he/him) |
@quietone @webchick As far as I understand people with data sets with node revisions they intend to keep (eg. accountability, rollback ability, etc) and content translation and/or entity translation |
| webchick |
I wonder if we could ask around at Acquia for a customer site that has those things |
| quietone |
for the three currently listed a having to go in first, their is only one that the migrate maintainer need to discuss, that is #3086238: getHighestId() should not fail when there is a destination id with type string |
| quietone |
The others are easier, one is just moving test code to a new file. |
| Gábor Hojtsy (he/him) |
@webchick re Acquia customer site, I asked Shannon to shop it around at Acquia PS, not sure if she had success… I am not sure she shopped it around at the right part of PS(?) |
| webchick |
I reached out on our Drupal channel |
| webchick |
We’ll see what happens |
4️⃣ Add checkrequirements to VariableTranslation source plugin
5️⃣ Migrate UI - use human-friendly module names on the Review form (edited)
6️⃣ Source count caching does not work for SQL sources
7️⃣ Default Value Migration Process plugin produces unexpected behavior when updating list field from D7 to D8
8️⃣ And my personal favorite: SQL source plugins: allow defining conditions in migration yml
9️⃣ migrate_tools: Show migrate plugins on the Migrate UI lists (not NR, just of interest -- project affiliation has been updated/fixed since last week)
Also, we should ping a committer, as we have a few issues RTBC that have been hanging around for a while.
| alison |
Good call. |
| webchick |
Got a list? :slightly_smiling_face: |
| quietone |
https://www.drupal.org/project/issues/search/drupal?project_issue_follow... |
| webchick |
That is a decent list! |
| webchick |
Any suggested review/commit order? Are there any that we should definitely try and get in before beta? |
| alison |
durn, crossed streams :ghostbusters: |
| webchick |
Oops, I’m sorry, I should probably be in the other thread. |
| alison |
nah i think we were like, simultaneous |
| quietone |
#3082719: migrate_drupal_migration_plugins_alter() should only alter definitions that exist |
| quietone |
#3017237: Use generators by default in source plugins |
| quietone |
I'd vote for those. @mikelutz, @heddn, what do you think? |
| webchick |
OK, sent a general heads-up about the RTBC queue wait-age to the committers at any rate. But if there are any “beta targets” that make API-ish changes or things like that, we only have about 8 more days to get those in, and many people are traveling to DrupalCon on at least one of those days :stuck_out_tongue: (edited) |
| alison |
@webchick Thank you! The date order will be a little off now, with the retests @quietone just added -- just a heads-up. |
| webchick |
Yep, understood. |
🔟 or, "3-a" -- a multilingual issue highlighted as in need of review by migrate maintainers:getHighestId() should not fail when there is a destination id with type string
1️⃣ :one: Ping committers on issues that have been RTBC for a while -->
| alison |
Ordered by "last updated the longest time ago":https://www.drupal.org/project/issues/drupal?text=&status=14&priorities=... |
| webchick |
^ So that’s quite a lot. Any recommended review/commit order? Any we should definitely try and get into beta1? |
| alison |
I'll poke around. (Ordered by "oldest" in terms of "last touched" -- so, that's a start.) |
| webchick |
Yep, that’s helpful. |
| alison |
Ok I'll check a few of the older ones for if they need any rerolling... and circle back here... -- that doesn't speak to "importance," that would take more effort/thinking than I have bandwidth for right now, but |
| quietone |
I just added retests of older ones on 8.9.x (edited) |
| alison |
@webchick I came up with a "top 4" -- totally just my perspective, obviously.1. This one has been committed to 8.8.x (and it was long enough ago to already be in 8.9.x, I just checked the code), but now it has a RTBC patch for porting to 8.7.x -- not "critical," but would be nice to wrap up, makes me uncomfortable having it hanging around.2. Tiny code comment change for the sake of improved documentation: #3082719: migrate_drupal_migration_plugins_alter() should only alter definitions that exist (edited) |
| alison |
(and that's it for me for today :slightly_smiling_face: thanks again!) |
1️⃣ 2️⃣ Last call for meeting topics!
Cool beans :beans: Thanks, everybody!Commence petering-out of formal "meeting" -- please scroll back and check out the linked-to issue threads, especially 3️⃣ and 🔟 (re: multilingual things).
| webchick |
I love that “bean” emoji :smile: |
| webchick |
Thanks so much for facilitating, Alison!! |
| quietone |
Yes, thank you. |
| alison |
My pleasure, thanks for your patience everyone! Happy every time I get to be here for a meeting :slightly_smiling_face: |
Participants:
webchick, damienmckenna, quietone, benjifisher, alison, Joshua Turton (srjosh), Gábor Hojtsy (he/him)
9️⃣ migrate_tools: Show migrate plugins on the Migrate UI lists (not NR, just of interest -- project affiliation has been updated/fixed since last week)
Also, we should ping a committer, as we have a few issues RTBC that have been hanging around for a while.
| alison |
Good call. |
| webchick |
Got a list? :slightly_smiling_face: |
| quietone |
https://www.drupal.org/project/issues/search/drupal?project_issue_follow... |
| webchick |
That is a decent list! |
| webchick |
Any suggested review/commit order? Are there any that we should definitely try and get in before beta? |
| alison |
durn, crossed streams :ghostbusters: |
| webchick |
Oops, I’m sorry, I should probably be in the other thread. |
| alison |
nah i think we were like, simultaneous |
| quietone |
#3082719: migrate_drupal_migration_plugins_alter() should only alter definitions that exist |
| quietone |
#3017237: Use generators by default in source plugins |
| quietone |
I'd vote for those. @mikelutz, @heddn, what do you think? |
| webchick |
OK, sent a general heads-up about the RTBC queue wait-age to the committers at any rate. But if there are any “beta targets” that make API-ish changes or things like that, we only have about 8 more days to get those in, and many people are traveling to DrupalCon on at least one of those days :stuck_out_tongue: (edited) |
| alison |
@webchick Thank you! The date order will be a little off now, with the retests @quietone just added -- just a heads-up. |
| webchick |
Yep, understood. |
🔟 or, "3-a" -- a multilingual issue highlighted as in need of review by migrate maintainers:getHighestId() should not fail when there is a destination id with type string
1️⃣ :one: Ping committers on issues that have been RTBC for a while -->
| alison |
Ordered by "last updated the longest time ago":https://www.drupal.org/project/issues/drupal?text=&status=14&priorities=... |
| webchick |
^ So that’s quite a lot. Any recommended review/commit order? Any we should definitely try and get into beta1? |
| alison |
I'll poke around. (Ordered by "oldest" in terms of "last touched" -- so, that's a start.) |
| webchick |
Yep, that’s helpful. |
| alison |
Ok I'll check a few of the older ones for if they need any rerolling... and circle back here... -- that doesn't speak to "importance," that would take more effort/thinking than I have bandwidth for right now, but |
| quietone |
I just added retests of older ones on 8.9.x (edited) |
| alison |
@webchick I came up with a "top 4" -- totally just my perspective, obviously.1. This one has been committed to 8.8.x (and it was long enough ago to already be in 8.9.x, I just checked the code), but now it has a RTBC patch for porting to 8.7.x -- not "critical," but would be nice to wrap up, makes me uncomfortable having it hanging around.2. Tiny code comment change for the sake of improved documentation: #3082719: migrate_drupal_migration_plugins_alter() should only alter definitions that exist (edited) |
| alison |
(and that's it for me for today :slightly_smiling_face: thanks again!) |
1️⃣ 2️⃣ Last call for meeting topics!
Cool beans :beans: Thanks, everybody!Commence petering-out of formal "meeting" -- please scroll back and check out the linked-to issue threads, especially 3️⃣ and 🔟 (re: multilingual things).
| webchick |
I love that “bean” emoji :smile: |
| webchick |
Thanks so much for facilitating, Alison!! |
| quietone |
Yes, thank you. |
| alison |
My pleasure, thanks for your patience everyone! Happy every time I get to be here for a meeting :slightly_smiling_face: |
Participants:
webchick, damienmckenna, quietone, benjifisher, alison, Joshua Turton (srjosh), Gábor Hojtsy (he/him)
Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comments
Comment #2
benjifisherPresent:
We reviewed the following issues
@webchick mentioned that she and Gabor have Tweeted about multilingual migrations, looking for real-world testing: https://twitter.com/webchick/status/1186769241086676992
We noticed that there are currently 8 issues marked RTBC that have been waiting 1 to 7 weeks.
Comment #4
quietone CreditAttribution: quietone as a volunteer commentedComment #7
quietone CreditAttribution: quietone as a volunteer commentedComment #10
quietone CreditAttribution: quietone as a volunteer commentedComment #11
quietone CreditAttribution: quietone as a volunteer commented