The caching in ConfigDeriverBase might be redundant. We already have schema_cache_tags, schema_cache_contexts and schema_cache_max_age in GraphQLAnnotationBase.

Comments

blazey created an issue. See original summary.

blazey’s picture

blazey CreditAttribution: blazey at Amazee Labs commented
Parent issue: » #3089087: Module rewrite to give more structured data,

  • blazey committed 2c7ca0d on 8.x-1.x 
    Issue #3090166 by blazey: Check if caching is redundant. Removed the...
blazey’s picture

blazey CreditAttribution: blazey at Amazee Labs commented
Status: Active » Fixed

The additional caching layer has been removed. It would be nice to use the schema_cache_tags, I don't know if that'll work with code-driven config changes though.

gordon’s picture

gordon CreditAttribution: gordon at Heydon Consulting commented

I thought that this was the other cache item on the ConfigObject, but the index which is built for the deriver is a very expensive process and the data is used across all 11 derivers. So without this cache will be built 11 times (As there is 11 derivers which use this). This is a very expensive process.

We really need to reinstate this cache.

  • blazey committed a078efc on 8.x-1.x 
    Revert "Issue #3090166 by blazey: Check if caching is redundant. Removed...
blazey’s picture

blazey CreditAttribution: blazey at Amazee Labs commented

Makes sense, thanks for pointing out. Reverted.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.